From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr5Jc-0001UT-I8 for qemu-devel@nongnu.org; Tue, 27 Oct 2015 10:33:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr5JY-0007SJ-Vf for qemu-devel@nongnu.org; Tue, 27 Oct 2015 10:33:32 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:34833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr5JY-0007Ru-Ou for qemu-devel@nongnu.org; Tue, 27 Oct 2015 10:33:28 -0400 Date: Tue, 27 Oct 2015 10:33:26 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1889109701.37758961.1445956406827.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1445869920-6029-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCHv2] tests: re-enable vhost-user-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , QEMU Developers , "Michael S. Tsirkin" Hi ----- Original Message ----- > On 26 October 2015 at 14:32, wrote: > > From: Marc-Andr=C3=A9 Lureau > > > > Commit 7fe34ca9c2e actually disabled vhost-user-test altogether, > > since CONFIG_VHOST_NET is a per-target config variable. > > > > tests/vhost-user-test is already x86/x64 softmmu specific test, in orde= r > > to enable it correctly, kvm & vhost-net are also conditions. To check > > that, set CONFIG_VHOST_NET_TEST_$target when kvm is also enabled. > > > > Since "check-qtest-x86_64-y =3D $(check-qtest-i386-y)", avoid duplicati= on > > when both x86 & x64 are enabled. > > > > Other targets than x86 aren't enabled yet, and is intentionally left as > > a future improvement, since I can't easily test those. > > > > Signed-off-by: Marc-Andr=C3=A9 Lureau >=20 > I ran this through my build-tests, which pass, but: >=20 > (a) there's still the clang warning about the negative shifts > in target-i386/. This is an ancient bug and we can fix it later. I sent a patch to fix this. > (b) there are new warning messages: > Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK > Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK > Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK These are part of qemu file_ram_alloc() > I would like (b) fixed -- tests should either: > (1) complete without printing "warning" about anything We would need to change the qemu warning. > (2) fail the test if the warning is actually important > (3) skip the test if the test requires something that the host > machine doesn't have (like a hugetlbfs) It is not important for the test to succeed. I imagine a few options to get rid of the warning: 1. only run the test on hugetlbfs 2. remove the warning from qemu 3. silence qemu errors in the test 4. add an option to memory-backend-file to require hugetlbfs: something lik= e ...,require-hugetlbfs=3Dtrue,false,warn I guess 4. is the most interesting, although I would need some advice on ho= w to express this best. (tbh, I think this could be addressed later)