Re: [PATCH] hw/vfio/helpers: Check base architecture at runtime

["Cédric Le Goater" <clg@redhat.com>]

On 10/21/25 00:23, Philippe Mathieu-Daudé wrote:
> Replace the compile time check of the TARGET_ARM definition
> by a runtime call to target_base_arm().
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Based-on: <20251020220941.65269-1-philmd@linaro.org>
> ---
>   hw/vfio/helpers.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/vfio/helpers.c b/hw/vfio/helpers.c
> index 23d13e5db5f..007c37b28b8 100644
> --- a/hw/vfio/helpers.c
> +++ b/hw/vfio/helpers.c
> @@ -20,6 +20,7 @@
>    */
>   
>   #include "qemu/osdep.h"
> +#include "qemu/target-info.h"
>   #include <sys/ioctl.h>
>   
>   #include "system/kvm.h"
> @@ -220,9 +221,5 @@ bool vfio_arch_wants_loading_config_after_iter(void)
>        * See commit d329f5032e17 ("vfio: Move the saving of the config space to
>        * the right place in VFIO migration").
>        */
> -#if defined(TARGET_ARM)
> -    return true;
> -#else
> -    return false;
> -#endif
> +    return target_base_arm();


is that a new helper ? I don't see it being used anywhere else.

Thanks,

C.