From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55947)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tracek@redhat.com>) id 1T254T-0003E0-Qg
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 14:45:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tracek@redhat.com>) id 1T254S-0004zY-L3
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 14:45:29 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:52221)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tracek@redhat.com>) id 1T254S-0004zK-BZ
	for qemu-devel@nongnu.org; Thu, 16 Aug 2012 14:45:28 -0400
Date: Thu, 16 Aug 2012 14:45:15 -0400 (EDT)
From: Tomas Racek <tracek@redhat.com>
Message-ID: <1898701172.1847948.1345142715802.JavaMail.root@redhat.com>
In-Reply-To: <20120816134834.GA11974@x1.osrc.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] x86, nops settings result in kernel crash
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Borislav Petkov <bp@alien8.de>
Cc: qemu-devel@nongnu.org, "H. Peter Anvin" <hpa@linux.intel.com>, linux-kernel@vger.kernel.org, Alan Cox <alan@linux.intel.com>

----- Original Message -----
> On Thu, Aug 16, 2012 at 09:35:12AM -0400, Tomas Racek wrote:
> > Hi,
> > 
> > I am writing a file system test which I execute in qemu with kernel
> > compiled from latest git sources and running it causes this error:
> > 
> > https://bugzilla.kernel.org/show_bug.cgi?id=45971
> > 
> > It works with v3.5, so I ran git bisect which pointed me to:
> > 
> > d6250a3f12edb3a86db9598ffeca3de8b4a219e9 x86, nops: Missing break
> > resulting in incorrect selection on Intel
> > 
> > To be quite honest, I don't understand this stuff much but I tried
> > to do some debugging and I figured out (I hope) that the crash is
> > caused by setting ideal_nops to p6_nops (k8_nops was used before
> > the break statement was added).
> 
> Maybe I overlooked it or maybe it was implied but did you try
> reverting
> the patch and rerunning your test? Does it work ok then?
> 

Yes, if I remove the break statement (introduced by this commit), it works fine.

Tomas

> Thanks.
> 
> --
> Regards/Gruss,
> Boris.
>