qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v5 3/5] optionrom: add new PVH option rom
Date: Mon, 21 Jan 2019 18:37:04 +0100	[thread overview]
Message-ID: <18a8918c-b4d6-1165-4064-d80c97316eec@redhat.com> (raw)
In-Reply-To: <20190118120143.21631-4-sgarzare@redhat.com>

On 18/01/19 13:01, Stefano Garzarella wrote:
> The new pvh.bin option rom can be used with SeaBIOS to boot
> uncompressed kernel using the x86/HVM direct boot ABI.
> 
> pvh.S contains the entry point of the option rom. It runs
> in real mode, loads the e820 table querying the BIOS, and
> then it switches to 32bit protected mode and jumps to the
> pvh_load_kernel() written in pvh_main.c.
> pvh_load_kernel() loads the cmdline and kernel entry_point
> using fw_cfg, then it looks for RSDP, fills the
> hvm_start_info required by x86/HVM ABI, and finally jumps
> to the kernel entry_point.
> 
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>

... and, for mingw:

diff --git a/pc-bios/optionrom/pvh_main.c b/pc-bios/optionrom/pvh_main.c
index d1b8b4b..a015e1b 100644
--- a/pc-bios/optionrom/pvh_main.c
+++ b/pc-bios/optionrom/pvh_main.c
@@ -43,7 +43,7 @@ struct pvh_e820_table {
     struct hvm_memmap_table_entry table[E820_MAXENTRIES];
 };

-struct pvh_e820_table pvh_e820 __attribute__ ((aligned));
+struct pvh_e820_table pvh_e820 asm("pvh_e820") __attribute__ ((aligned));

 static struct hvm_start_info start_info;
 static struct hvm_modlist_entry ramdisk_mod;


Paolo

  reply	other threads:[~2019-01-21 17:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 12:01 [Qemu-devel] [PATCH v5 0/5] pvh: add new PVH option rom Stefano Garzarella
2019-01-18 12:01 ` [Qemu-devel] [PATCH v5 1/5] linuxboot_dma: remove duplicate definitions of FW_CFG Stefano Garzarella
2019-01-18 12:01 ` [Qemu-devel] [PATCH v5 2/5] linuxboot_dma: move common functions in a new header Stefano Garzarella
2019-01-21 15:43   ` Paolo Bonzini
2019-01-21 16:20     ` Stefano Garzarella
2019-01-18 12:01 ` [Qemu-devel] [PATCH v5 3/5] optionrom: add new PVH option rom Stefano Garzarella
2019-01-21 17:37   ` Paolo Bonzini [this message]
2019-01-18 12:01 ` [Qemu-devel] [PATCH v5 4/5] hw/i386/pc: use " Stefano Garzarella
2019-01-21 17:05   ` Eduardo Habkost
2019-01-21 17:36     ` Stefano Garzarella
2019-01-21 18:33       ` Paolo Bonzini
2019-01-22  9:22         ` Stefano Garzarella
2019-01-22  9:29           ` Paolo Bonzini
2019-01-22  9:38             ` Stefano Garzarella
2019-01-18 12:01 ` [Qemu-devel] [PATCH v5 5/5] optionrom/pvh: load initrd from fw_cfg Stefano Garzarella
2019-01-21 10:17 ` [Qemu-devel] [PATCH v5 0/5] pvh: add new PVH option rom Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18a8918c-b4d6-1165-4064-d80c97316eec@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).