From: Richard Henderson <rth@twiddle.net>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH-for-5.0?] decodetree: Use Python3 floor division operator
Date: Mon, 30 Mar 2020 11:46:23 -0700 [thread overview]
Message-ID: <18ac6d57-049e-4b45-0c9e-27190d832b50@twiddle.net> (raw)
In-Reply-To: <ed9ac5c8-0654-3c74-3e35-5d7b02a548b6@twiddle.net>
On 3/30/20 10:14 AM, Richard Henderson wrote:
> On 3/30/20 5:13 AM, Philippe Mathieu-Daudé wrote:
>> This script started using Python2, where the 'classic' division
>> operator returns the floor result. In commit 3d004a371 we started
>> to use Python3, where the division operator returns the float
>> result ('true division').
>> To keep the same behavior, use the 'floor division' operator "//"
>> which returns the floor result.
>>
>> Fixes: 3d004a371
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> We didn't notice it because only the RX port (which uses the
>> --varinsnwidth option, and got merged very recently) triggers
>> these problems.
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> scripts/decodetree.py | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Queued to tcg-next for 5.0.
r~
next prev parent reply other threads:[~2020-03-30 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 12:13 [PATCH-for-5.0?] decodetree: Use Python3 floor division operator Philippe Mathieu-Daudé
2020-03-30 12:54 ` Peter Maydell
2020-03-30 17:14 ` Richard Henderson
2020-03-30 18:46 ` Richard Henderson [this message]
2020-03-30 23:28 ` Aleksandar Markovic
2020-03-30 23:53 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ac6d57-049e-4b45-0c9e-27190d832b50@twiddle.net \
--to=rth@twiddle.net \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).