From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Eduardo Habkost <eduardo@habkost.net>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
incoming+7b48dc26643084f29a2bbb8c07f757b1@incoming.gitlab.com
Subject: Re: [RFC PATCH] target/i386: for maximum rounding precision for fildll
Date: Mon, 7 Mar 2022 11:33:24 -1000 [thread overview]
Message-ID: <18ad7e7a-2444-1ff2-cce9-caeaadd40cfa@linaro.org> (raw)
In-Reply-To: <87h789fprz.fsf@linaro.org>
On 3/7/22 10:48, Alex Bennée wrote:
>> Need a similar fix for fildl_ST0, for the case floatx80_precision_s is
>> currently set (int32_t has more than the 23 bits of single-precision).
>
> It can't hurt to convert with:
>
> set_floatx80_rounding_precision(floatx80_precision_x, &env->fp_status);
>
> in that case as well right?
s/can't hurt/is required/ was my point.
Followup patch looks good:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2022-03-07 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 18:44 [RFC PATCH] target/i386: for maximum rounding precision for fildll Alex Bennée
2022-03-07 19:47 ` Richard Henderson
2022-03-07 20:48 ` Alex Bennée
2022-03-07 21:33 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ad7e7a-2444-1ff2-cce9-caeaadd40cfa@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=incoming+7b48dc26643084f29a2bbb8c07f757b1@incoming.gitlab.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).