From: Richard Henderson <richard.henderson@linaro.org>
To: "Qi Hu" <huqi@loongson.cn>, "Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: Song Gao <gaosong@loongson.cn>,
Xiaojuan Yang <yangxiaojuan@loongson.cn>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] disas: Add LoongArch support
Date: Thu, 4 Aug 2022 11:23:32 -0700 [thread overview]
Message-ID: <18b3de0c-593e-57c5-4277-c15ba9c2cc2f@linaro.org> (raw)
In-Reply-To: <20220804172939.325306-1-huqi@loongson.cn>
On 8/4/22 10:29, Qi Hu wrote:
> Signed-off-by: Qi Hu <huqi@loongson.cn>
> ---
> disas.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/disas.c b/disas.c
> index e31438f349..d44feeee46 100644
> --- a/disas.c
> +++ b/disas.c
> @@ -176,6 +176,8 @@ static void initialize_debug_host(CPUDebug *s)
> #else
> #error unsupported RISC-V ABI
> #endif
> +#elif defined(__loongarch__)
> + s->info.print_insn = print_insn_loongarch;
This is very much insufficient. Try --target-list=i386-softmmu and watch it fail to link.
You need to modify the build rules to make certain that the loongarch disassembler is
built for loongarch host.
r~
next prev parent reply other threads:[~2022-08-04 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 17:29 [PATCH] disas: Add LoongArch support Qi Hu
2022-08-04 18:08 ` Peter Maydell
2022-08-04 18:23 ` Richard Henderson [this message]
2022-08-06 9:23 ` Qi Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18b3de0c-593e-57c5-4277-c15ba9c2cc2f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=huqi@loongson.cn \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).