From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm/tcg: Don't build AArch64 decodetree files for qemu-system-arm
Date: Tue, 18 Jul 2023 14:05:00 +0200 [thread overview]
Message-ID: <18b9ca41-c901-ac61-c959-5d8c36341a7f@linaro.org> (raw)
In-Reply-To: <20230718104628.1137734-1-peter.maydell@linaro.org>
On 18/7/23 12:46, Peter Maydell wrote:
> Currently we list all the Arm decodetree files together and add them
> unconditionally to arm_ss. This means we build them for both
> qemu-system-aarch64 and qemu-system-arm. However, some of them are
> AArch64-specific, so there is no need to build them for
> qemu-system-arm. (Meson is smart enough to notice that the generated
> .c.inc file is not used by any objects that go into qemu-system-arm,
> so we only unnecessarily run decodetree, not anything more
> heavyweight like a recompile or relink, but it's still unnecessary
> work.)
>
> Split gen into gen_a32 and gen_a64, and only add gen_a64 for
> TARGET_AARCH64 compiles.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/tcg/meson.build | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-07-18 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 10:46 [PATCH] target/arm/tcg: Don't build AArch64 decodetree files for qemu-system-arm Peter Maydell
2023-07-18 12:05 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18b9ca41-c901-ac61-c959-5d8c36341a7f@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).