From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Willian Rampazzo" <willianr@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus
Date: Wed, 15 Sep 2021 16:10:49 +0200 [thread overview]
Message-ID: <18bf095c-719c-d6e9-780e-3a7e3c682092@redhat.com> (raw)
In-Reply-To: <20210915125452.1704899-3-berrange@redhat.com>
On 15/09/2021 14.54, Daniel P. Berrangé wrote:
> A typo meant the substitution would not work, and the placeholder in the
> target file didn't even exist.
>
> The result was that tests were never run on the FreeBSD and macOS jobs,
> only a basic build.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/cirrus.yml | 2 +-
> .gitlab-ci.d/cirrus/build.yml | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
> index 675db69622..e7b25e7427 100644
> --- a/.gitlab-ci.d/cirrus.yml
> +++ b/.gitlab-ci.d/cirrus.yml
> @@ -35,7 +35,7 @@
> -e "s|[@]PIP3@|$PIP3|g"
> -e "s|[@]PYPI_PKGS@|$PYPI_PKGS|g"
> -e "s|[@]CONFIGURE_ARGS@|$CONFIGURE_ARGS|g"
> - -e "s|[@]TEST_TARGETSS@|$TEST_TARGETSS|g"
> + -e "s|[@]TEST_TARGETS@|$TEST_TARGETS|g"
Ooops, missed that in the review :-/
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-09-15 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 12:54 [PATCH 0/2] gitlab: some minor CI tweaks Daniel P. Berrangé
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
2021-09-15 14:11 ` Thomas Huth
2021-09-15 14:59 ` Philippe Mathieu-Daudé
2021-09-15 12:54 ` [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
2021-09-15 14:10 ` Thomas Huth [this message]
2021-09-15 14:35 ` Willian Rampazzo
2021-09-17 11:23 ` [PATCH 0/2] gitlab: some minor CI tweaks Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18bf095c-719c-d6e9-780e-3a7e3c682092@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).