From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGiW-0004kT-Ja for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:47:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhGiS-0002nI-03 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:47:11 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:49365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGiR-0002n8-Mx for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:47:07 -0400 Date: Tue, 6 Sep 2016 09:47:05 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1903802153.27873.1473169625794.JavaMail.zimbra@redhat.com> In-Reply-To: <20160906134407.GJ10095@redhat.com> References: <20160906133637.32147-1-marcandre.lureau@redhat.com> <20160906134407.GJ10095@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] tests: fix small leak in test-io-channel-command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , peter.maydell@linaro.org Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org Hi ----- Original Message ----- > On Tue, Sep 06, 2016 at 05:36:37PM +0400, Marc-Andr=C3=A9 Lureau wrote: > > srcfifo && dstfifo must still be freed if socat is not present. > >=20 > > Only unlink if the fifo was actually created. > >=20 > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > --- > > tests/test-io-channel-command.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > Signed-off-by: Daniel P. Berrange >=20 > I'll add this to my I/O queue unless you respin your current PULL request > with this included. I don't know what's best. Peter, should I send a new pull request with the = new patch? Or send a new one without it? Or you can pull the current reques= t without this patch? thanks >=20 > Regards, > Daniel > -- > |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| > |: http://libvirt.org -o- http://virt-manager.or= g :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :| >=20