From: Alon Levy <alevy@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block
Date: Tue, 4 Jun 2013 16:59:34 -0400 (EDT) [thread overview]
Message-ID: <1906731494.14304293.1370379574347.JavaMail.root@redhat.com> (raw)
In-Reply-To: <51AE5249.3060401@redhat.com>
> Il 04/06/2013 22:23, Alon Levy ha scritto:
> > This fixes six instances of unchecked fcntl return status, spotted by
> > Coverity.
>
> I think we're just assuming that they cannot fail... I don't think we
> need the previous patch and this one, unless they help porting stuff to
> Windows.
This was purely to satisfy coverity, but I thought we would want to check fcntl return status? also, shouldn't we be looping if EINTR?
>
> Paolo
>
>
next prev parent reply other threads:[~2013-06-04 20:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 20:23 [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block Alon Levy
2013-06-04 20:23 ` [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block Alon Levy
2013-06-04 20:47 ` Paolo Bonzini
2013-06-04 20:59 ` Alon Levy [this message]
2013-06-04 21:08 ` Peter Maydell
2013-06-04 20:50 ` Peter Maydell
2013-06-04 20:56 ` Alon Levy
2013-06-04 20:23 ` [Qemu-devel] [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths Alon Levy
2013-06-04 20:55 ` Peter Maydell
2013-06-12 12:09 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-04 20:23 ` [Qemu-devel] [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference Alon Levy
2013-06-04 21:06 ` Peter Maydell
2013-06-04 20:23 ` [Qemu-devel] [PATCH 5/5] libcacard/vscclient.c: fix use of uninitialized variable Alon Levy
2013-06-04 21:12 ` Peter Maydell
2013-06-04 20:48 ` [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block Peter Maydell
2013-06-04 21:11 ` Eric Blake
2013-06-04 21:41 ` Alon Levy
2013-06-05 19:43 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-12 9:38 ` Michael Tokarev
2013-06-12 11:21 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1906731494.14304293.1370379574347.JavaMail.root@redhat.com \
--to=alevy@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).