From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C001DC00A89 for ; Thu, 5 Nov 2020 05:32:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB4632083B for ; Thu, 5 Nov 2020 05:32:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wt1254q1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB4632083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaXtA-0002Rj-Dy for qemu-devel@archiver.kernel.org; Thu, 05 Nov 2020 00:32:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaXrz-0001v8-2O for qemu-devel@nongnu.org; Thu, 05 Nov 2020 00:31:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:51160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kaXrw-0007C7-Ec for qemu-devel@nongnu.org; Thu, 05 Nov 2020 00:31:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604554291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J9F2OvdSw023WuSWXgiqcvZxf582+OCcLM4MuDkbfwY=; b=Wt1254q1kujN7HjYnJzYwsGTKs3AtOvaFjQe/SPSBfpMklGTKKdaaz0ahY63O228QcFq9a EbpquRQd6bsBAaa3lFaSDUNb7qT7YXPZ3wideXKBDHJmqsmEibN1hPt4mgOdIVW/jxpi8/ 5NsFpusfDNmHzKMpfybR8L/Ip8ZO1z4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-Fw8q6bX3OlCZXf2bepfSLQ-1; Thu, 05 Nov 2020 00:31:27 -0500 X-MC-Unique: Fw8q6bX3OlCZXf2bepfSLQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1F7D8015B1; Thu, 5 Nov 2020 05:31:25 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-117.ams2.redhat.com [10.36.112.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3B565D9D5; Thu, 5 Nov 2020 05:31:23 +0000 (UTC) Subject: Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device To: Mark Cave-Ayland , armbru@redhat.com, david@gibson.dropbear.id.au, atar4qemu@gmail.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org References: <20200926140216.7368-1-mark.cave-ayland@ilande.co.uk> <20200926140216.7368-6-mark.cave-ayland@ilande.co.uk> <16f13e17-37cb-a238-4e2a-9a945649cafd@redhat.com> <24aca485-fe87-8aab-7554-ba8dc1a3bbb3@ilande.co.uk> From: Thomas Huth Message-ID: <19068e17-21f0-75a5-f7df-1b11404008c6@redhat.com> Date: Thu, 5 Nov 2020 06:31:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <24aca485-fe87-8aab-7554-ba8dc1a3bbb3@ilande.co.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/04 22:46:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 04/11/2020 20.29, Mark Cave-Ayland wrote: > On 04/11/2020 12:47, Thomas Huth wrote: > >> On 26/09/2020 16.02, Mark Cave-Ayland wrote: >>> Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the >>> Mac Old World and New World machine level. >>> >>> Also remove the now obsolete comment referring to the use of serial_hd() and >>> the setting of user_creatable to false accordingly. >>> >>> Signed-off-by: Mark Cave-Ayland >>> --- >>>   hw/misc/macio/macio.c | 4 ---- >>>   hw/ppc/mac_newworld.c | 6 ++++++ >>>   hw/ppc/mac_oldworld.c | 6 ++++++ >>>   3 files changed, 12 insertions(+), 4 deletions(-) >>> >>> diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c >>> index 679722628e..51368884d0 100644 >>> --- a/hw/misc/macio/macio.c >>> +++ b/hw/misc/macio/macio.c >>> @@ -109,8 +109,6 @@ static void macio_common_realize(PCIDevice *d, Error >>> **errp) >>>       qdev_prop_set_uint32(DEVICE(&s->escc), "disabled", 0); >>>       qdev_prop_set_uint32(DEVICE(&s->escc), "frequency", ESCC_CLOCK); >>>       qdev_prop_set_uint32(DEVICE(&s->escc), "it_shift", 4); >>> -    qdev_prop_set_chr(DEVICE(&s->escc), "chrA", serial_hd(0)); >>> -    qdev_prop_set_chr(DEVICE(&s->escc), "chrB", serial_hd(1)); >>>       qdev_prop_set_uint32(DEVICE(&s->escc), "chnBtype", escc_serial); >>>       qdev_prop_set_uint32(DEVICE(&s->escc), "chnAtype", escc_serial); >>>       if (!qdev_realize(DEVICE(&s->escc), BUS(&s->macio_bus), errp)) { >>> @@ -458,8 +456,6 @@ static void macio_class_init(ObjectClass *klass, void >>> *data) >>>       k->class_id = PCI_CLASS_OTHERS << 8; >>>       device_class_set_props(dc, macio_properties); >>>       set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); >>> -    /* Reason: Uses serial_hds in macio_instance_init */ >>> -    dc->user_creatable = false; >>>   } >> >>   Hi Mark, >> >> the macio device can now be used to crash QEMU: >> >>   $ ./qemu-system-ppc -M sam460ex -device macio-newworld >>   Segmentation fault (core dumped) >> >> I guess we should either restore the user_creatable flag or add some sanity >> checks elsewhere? > > (goes and looks) > > Ah okay it appears to be because the object property link to the PIC is > missing, which is to be expected as it is only present on the Mac machines. > > With the latest round of QOM updates I can see the solution but it's > probably a bit much now that we've reached rc-0. The easiest thing for the > moment is to switch user_creatable back to false if this is causing an issue. +1 for setting user_creatable back to false ... can you send a patch or shall I prepare one? > Just out of interest how did you find this? My new workflow involves a local > "make check" with all ppc targets and a pass through Travis-CI and it didn't > show up there for me (or indeed Peter's pre-merge tests). I've found it with the scripts/device-crash-test script. (You currently need to apply Eduardo's patch "Check if path is actually an executable file" on top first to run it) Thomas