* Re: [Qemu-devel] Why only devdax guarantees guest data persistence ?
2019-02-20 15:36 ` Stefan Hajnoczi
@ 2019-02-20 16:18 ` Dan Williams
2019-02-20 16:22 ` Pankaj Gupta
1 sibling, 0 replies; 4+ messages in thread
From: Dan Williams @ 2019-02-20 16:18 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: bipin.tomar@yahoo.com, qemu-devel@nongnu.org, Ross Zwisler,
Jeff Moyer, Pankaj Gupta
On Wed, Feb 20, 2019 at 7:37 AM Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
> On Fri, Feb 15, 2019 at 05:09:31PM +0000, bipin.tomar--- via Qemu-devel wrote:
> > Text from "docs/nvdimm.txt" says:
> > Guest Data Persistence
> > ----------------------
> >
> > Though QEMU supports multiple types of vNVDIMM backends on Linux,
> > currently the only one that can guarantee the guest write persistence
> > is the device DAX on the real NVDIMM device (e.g., /dev/dax0.0), to
> > which all guest access do not involve any host-side kernel cache.
> >
> > I think here "host-side kernel cache" imply "page cache". Why does fsdax NOT have the same persistence guarantees as devdax for vNVDIMM?
> > Both the modes avoid using page cache then why is devdax explicitly called out?
>
> File systems may require msync(2)/fsync(2) to guarantee persistence even
> with DAX (just a cache flush instruction may not be enough!). Emulated
> NVDIMM devices lack an fsync interface so guests are unable to fsync the
> host file system.
>
> This is not an issue with devdax since there is no host file system.
>
> virtio-pmem is an effort to add a paravirtualized fsync-style interface
> and should solve this problem in the future:
> https://lkml.org/lkml/2019/1/9/541
A para-virtualized flush is only necessary if the host implements
caches and dirty-metadata that cannot be coordinated / flushed by
MAP_SYNC. virtio-pmem is not a solution to a problem, virtio-pmem is a
non-DAX alternative implementation of persistent memory that requires
the guest to coordinate metadata and host page cache flushing.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] Why only devdax guarantees guest data persistence ?
2019-02-20 15:36 ` Stefan Hajnoczi
2019-02-20 16:18 ` Dan Williams
@ 2019-02-20 16:22 ` Pankaj Gupta
1 sibling, 0 replies; 4+ messages in thread
From: Pankaj Gupta @ 2019-02-20 16:22 UTC (permalink / raw)
To: bipin tomar
Cc: Stefan Hajnoczi, qemu-devel, Dan Williams, Ross Zwisler,
Jeff Moyer
> wrote:
> > Text from "docs/nvdimm.txt" says:
> > Guest Data Persistence
> > ----------------------
> >
> > Though QEMU supports multiple types of vNVDIMM backends on Linux,
> > currently the only one that can guarantee the guest write persistence
> > is the device DAX on the real NVDIMM device (e.g., /dev/dax0.0), to
> > which all guest access do not involve any host-side kernel cache.
> >
> > I think here "host-side kernel cache" imply "page cache". Why does fsdax
> > NOT have the same persistence guarantees as devdax for vNVDIMM?
> > Both the modes avoid using page cache then why is devdax explicitly called
> > out?
>
> File systems may require msync(2)/fsync(2) to guarantee persistence even
> with DAX (just a cache flush instruction may not be enough!). Emulated
> NVDIMM devices lack an fsync interface so guests are unable to fsync the
> host file system.
Just want to add to what Stefan already said.
For emulated vNVDIMM on regular storage like SSD we require an additional
fsync on host backing file to guarantee write persistence (i.e fsync host
page cache pages) and consistent host metadata.
If backing file is real NVDIMM, write persistence is taken care by host NVDIMM
driver and MAP_SYNC support takes care of metadata consistency in-case of guest
crash.
>
> This is not an issue with devdax since there is no host file system.
Yes.
>
> virtio-pmem is an effort to add a paravirtualized fsync-style interface
> and should solve this problem in the future:
> https://lkml.org/lkml/2019/1/9/541
>
> Stefan
>
^ permalink raw reply [flat|nested] 4+ messages in thread