From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62377C43470 for ; Fri, 23 Apr 2021 11:05:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91CAC61474 for ; Fri, 23 Apr 2021 11:05:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91CAC61474 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZtch-0005Qv-Ex for qemu-devel@archiver.kernel.org; Fri, 23 Apr 2021 07:05:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZtbP-00050a-RV for qemu-devel@nongnu.org; Fri, 23 Apr 2021 07:04:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53171) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZtbI-0006FP-VE for qemu-devel@nongnu.org; Fri, 23 Apr 2021 07:04:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619175835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wu0zBx09P2kErGwSToto3XrMufavyh6FOP1GISHBg/A=; b=DG0gAAyfEx2ii1R9gbZgzqM5oBFMNbR3ikM8nDV1PZ+Hk2SexmqnXJ94pId6+95KcJoEEe 0rYJ3G4/O55eEK4QqN0SJuooEuTzFrc6jiiWwX51JHHEEUaxVvcQPOh0+fxnblD78WRGN0 lVkOj7VFbSB+IWr0FikQiuV837aX1Xg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-488-UvrGi9a-Mte3ZszrETqxpA-1; Fri, 23 Apr 2021 07:03:52 -0400 X-MC-Unique: UvrGi9a-Mte3ZszrETqxpA-1 Received: by mail-wm1-f70.google.com with SMTP id v65-20020a1cde440000b029012853a35ee7so526143wmg.2 for ; Fri, 23 Apr 2021 04:03:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Wu0zBx09P2kErGwSToto3XrMufavyh6FOP1GISHBg/A=; b=sDdRiJhSTCkmj0Sgk7D2AWBMUou9zhM4jtnjRJCwoFA8L40eSG5lHdPb2iUgn9+8FE ffbPOEsX6fBkFKcpN8NOMN+Jwfu6eKQwq9tFb430l4E55ren/gyM2L+IxBFXQIsdLQTL eUxOe6jqLhfWpwnJVhkDmLT62lpUJFk+8OcuQFhKywWnoe5+Mv9/CZWPf3hH1UqW5YHA 1LN/vpCX/tU0OMOiURjoTjU6DwweiNo8KoED4fuHl/M8eDSvNtP1Mj9NlaRBp0I3hNiY SZyjDbicObPRtm4y0gVZI8iKfomCDahgEklTDbPM4H8NmNQoZJhqZnJpl0cbQTGhEQas Nd+A== X-Gm-Message-State: AOAM531z0uH9oM7Rlb5CYnYC7QGatJ7ICAIWCZGj4Djb/dSjyjL5Imn8 ZsAxVojTfjAt2gRi0yQXyNRUFq5LKv70HXr24yTOsgZUTdcpM3cEogZ8l8uJ1jwK00DaEmcroKd xsNE0WWfIiACnqpw= X-Received: by 2002:adf:e58f:: with SMTP id l15mr3893172wrm.175.1619175830908; Fri, 23 Apr 2021 04:03:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX7kSGToWbWzohBobJ0HkvAD34Immjt45rJaaHQERvqHvvyDwfnDTUKbRcVSUWrUTtEFs1XA== X-Received: by 2002:adf:e58f:: with SMTP id l15mr3893128wrm.175.1619175830623; Fri, 23 Apr 2021 04:03:50 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6365.dip0.t-ipconnect.de. [91.12.99.101]) by smtp.gmail.com with ESMTPSA id k7sm8618312wrw.64.2021.04.23.04.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 04:03:50 -0700 (PDT) Subject: Re: [PATCH v6 14/15] qmp: Include "reserve" property of memory backends To: Markus Armbruster References: <20210421122624.12292-1-david@redhat.com> <20210421122624.12292-15-david@redhat.com> <87im4di7u9.fsf@dusky.pond.sub.org> From: David Hildenbrand Organization: Red Hat Message-ID: <190f173c-b3f9-6c70-42bb-27f50a5f9380@redhat.com> Date: Fri, 23 Apr 2021 13:03:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87im4di7u9.fsf@dusky.pond.sub.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Apfelbaum , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Peter Xu , "Dr. David Alan Gilbert" , Greg Kurz , Paolo Bonzini , Stefan Hajnoczi , Murilo Opsfelder Araujo , Igor Mammedov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23.04.21 13:00, Markus Armbruster wrote: > David Hildenbrand writes: > >> Let's include the new property. >> >> Reviewed-by: Philippe Mathieu-Daudé >> Cc: Eric Blake >> Cc: Markus Armbruster >> Cc: Igor Mammedov >> Signed-off-by: David Hildenbrand >> --- >> hw/core/machine-qmp-cmds.c | 1 + >> qapi/machine.json | 4 ++++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c >> index d41db5b93b..2d135ecdd0 100644 >> --- a/hw/core/machine-qmp-cmds.c >> +++ b/hw/core/machine-qmp-cmds.c >> @@ -175,6 +175,7 @@ static int query_memdev(Object *obj, void *opaque) >> m->dump = object_property_get_bool(obj, "dump", &error_abort); >> m->prealloc = object_property_get_bool(obj, "prealloc", &error_abort); >> m->share = object_property_get_bool(obj, "share", &error_abort); >> + m->reserve = object_property_get_bool(obj, "reserve", &error_abort); >> m->policy = object_property_get_enum(obj, "policy", "HostMemPolicy", >> &error_abort); >> host_nodes = object_property_get_qobject(obj, >> diff --git a/qapi/machine.json b/qapi/machine.json >> index 32650bfe9e..5932139d20 100644 >> --- a/qapi/machine.json >> +++ b/qapi/machine.json >> @@ -798,6 +798,9 @@ >> # >> # @share: whether memory is private to QEMU or shared (since 6.1) >> # >> +# @reserve: whether swap space (or huge pages) was reserved if applicable >> +# (since 6.1) >> +# >> # @host-nodes: host nodes for its memory policy >> # >> # @policy: memory policy of memory backend >> @@ -812,6 +815,7 @@ >> 'dump': 'bool', >> 'prealloc': 'bool', >> 'share': 'bool', >> + 'reserve': 'bool', >> 'host-nodes': ['uint16'], >> 'policy': 'HostMemPolicy' }} > > Double-checking: true means definitely reserved, and false means > definitely not reserved. Correct? True means "reserved if applicable" which means "not reserved if not applicable". False means "definitely not reserved". (any recommendation how to rephrase are appreciated; I tried my best -- this interface here makes it especially hard -- it's easier for the property itself) -- Thanks, David / dhildenb