From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: Failing property setters + hardwired devices + -global = a bad day
Date: Wed, 29 Apr 2020 17:39:20 +0200 [thread overview]
Message-ID: <1915d102-9528-9c31-8a8c-a84f7842fbe9@redhat.com> (raw)
In-Reply-To: <87mu6uia5i.fsf@dusky.pond.sub.org>
On 29/04/20 17:28, Markus Armbruster wrote:
> When an object gets created, its memory is zeroed, and then any class
> properties with an ->init() are initialized with
>
> obj->init(obj, prop);
>
> We have just one ->init():
>
> void object_property_init_defval(Object *obj, ObjectProperty *prop)
>
> It initializes from ->defval using ->set().
>
> Aside: feels overengineered, but let's move on.
>
> For TYPE_DEVICE objects, "static" properties get initialized the same.
>
> Aside: if I know what "static" means, I'll be hanged.
Originally these were the only properties that were part of the class
rather than the object (so, not dynamic --> static).
> I'd love to deprecate -global wholesale, but we can't as long as we
> don't have better means to configure onboard devices. Can we deprecate
> its use with backend properties at least?
I wouldn't mind deprecating -global wholesale, leaving the global/compat
props code only for internal usage.
Paolo
next prev parent reply other threads:[~2020-04-29 15:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 15:28 Failing property setters + hardwired devices + -global = a bad day Markus Armbruster
2020-04-29 15:39 ` Paolo Bonzini [this message]
2020-04-29 16:23 ` Eduardo Habkost
2020-04-29 15:57 ` Daniel P. Berrangé
2020-04-30 7:09 ` Markus Armbruster
2020-04-30 9:27 ` Peter Maydell
2020-04-30 10:03 ` Configuring onboard devices (was: Failing property setters + hardwired devices + -global = a bad day) Markus Armbruster
2020-04-30 10:29 ` Mark Cave-Ayland
2020-04-30 14:11 ` Configuring onboard devices Markus Armbruster
2020-04-30 14:32 ` Mark Cave-Ayland
2020-04-30 15:20 ` Markus Armbruster
2020-04-30 16:56 ` Mark Cave-Ayland
2020-05-02 5:47 ` Markus Armbruster
2020-05-03 22:13 ` Mark Cave-Ayland
2020-05-04 16:30 ` Eduardo Habkost
2020-04-30 10:34 ` Configuring onboard devices (was: Failing property setters + hardwired devices + -global = a bad day) Daniel P. Berrangé
2020-04-30 10:45 ` Peter Maydell
2020-04-30 10:53 ` Daniel P. Berrangé
2020-04-30 14:38 ` Configuring onboard devices Markus Armbruster
2020-04-30 10:54 ` Configuring onboard devices (was: Failing property setters + hardwired devices + -global = a bad day) Mark Cave-Ayland
2020-04-30 14:27 ` Configuring onboard devices Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1915d102-9528-9c31-8a8c-a84f7842fbe9@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).