From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, Claudio Fontana <cfontana@suse.de>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system'
Date: Wed, 4 Oct 2023 16:06:36 +0200 [thread overview]
Message-ID: <191a6af3-489b-04bc-0afb-092bdb437a47@linaro.org> (raw)
In-Reply-To: <CABgObfZBTZZvcSPcMSRLWscyEz7B-2h9g28FJx7t7Ggux6E9cA@mail.gmail.com>
On 4/10/23 15:49, Paolo Bonzini wrote:
> On Wed, Oct 4, 2023 at 3:41 PM Claudio Fontana <cfontana@suse.de> wrote:
>>
>> On 10/4/23 14:37, Thomas Huth wrote:
>>> On 04/10/2023 14.33, Daniel P. Berrangé wrote:
>>>> Am I mis-understanding what you mean by 'finishes' here, as
>>>> I see many references to softmmu remaining
>>>> In particular under configs/
>>>>
>>>> I was also hoping it meant that we'd be changing configure
>>>> to allow
>>>>
>>>> configure --target-list=x86_64-system
>>>> configure --target-list=x86_64-vm
>>>>
>>>> for less typing
>>>
>>> Maybe we should also bikeshed about the naming first... "system" is a quite
>>> overloaded word in this context already, and "vm" sounds rather like
>>> hardware-accelerated stuff ... what about using something like "sysemu"? Or
>>> "fullsys" for "full system emulation" (in contrast to "user space"-only
>>> emulation)?
>
> I agree that changing other remnants should be done right
> after this patch, for example $softmmu in configure. Changing
> all targets is a very large and very user-visible change, it is
> required but it should be planned very well.
As usual I should have been more verbose in my cover.
This series focus on the C code (and travis) to avoid misuse
of 'softmmu'.
Yes I agree it would be nice to also rename the binaries, but
this is a buildsys change (even if we use symlinks/aliases for
some deprecation period). This is not a tiny patch, and requires
thoughts.
On one hand I'd rather not rush renaming binaries -- annoying
users -- without a clear long term plan (which I'm not clear about).
On another hand I wouldn't delay Richard user-mode work.
Renaming binaries seems orthogonal to me, and could be done
later IMO.
> As to the actual target names, I think system is the only
> consistent choice since we have --enable/--disable-system
> (as pointed out by Claudio) and qemu-system-*. sysemu
> may make a little more sense in the codebase (we have
> include/sysemu after all), but maybe that ship has sailed
> since we have many occurrences of "system", for example
> system_ss and other related sourcesets.
>
> Paolo
>
next prev parent reply other threads:[~2023-10-04 14:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 9:06 [PATCH 00/13] misc: Rename 'softmmu' -> 'system' Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 01/13] softmmu/trace-events: Fix a typo Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 02/13] travis-ci: Correct invalid mentions of 'softmmu' by 'system' Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 03/13] cpu: Correct invalid mentions of 'softmmu' by 'system-mode' Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 04/13] fuzz: Correct invalid mentions of 'softmmu' by 'system' Philippe Mathieu-Daudé
2023-10-04 9:22 ` Alexander Bulekov
2023-10-04 9:06 ` [PATCH 05/13] tcg: Correct invalid mentions of 'softmmu' by 'system-mode' Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 06/13] accel: Rename accel_softmmu* -> accel_system* Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 07/13] gdbstub: Rename 'softmmu' -> 'system' Philippe Mathieu-Daudé
2023-10-04 15:23 ` Alex Bennée
2023-10-04 9:06 ` [PATCH 08/13] semihosting: Rename softmmu_FOO_user() -> uaccess_FOO_user() Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 09/13] target/i386: Rename i386_softmmu_kvm_ss -> i386_kvm_ss Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 10/13] hw/virtio/meson: Rename softmmu_virtio_ss -> system_virtio_ss Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 11/13] meson: Rename softmmu_mods -> system_mods Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 12/13] meson: Rename target_softmmu_arch -> target_system_arch Philippe Mathieu-Daudé
2023-10-04 9:06 ` [PATCH 13/13] system: Rename softmmu/ directory as system/ Philippe Mathieu-Daudé
2023-10-04 12:03 ` Philippe Mathieu-Daudé
2023-10-04 12:46 ` BALATON Zoltan
2023-10-04 12:33 ` [PATCH 00/13] misc: Rename 'softmmu' -> 'system' Daniel P. Berrangé
2023-10-04 12:37 ` Thomas Huth
2023-10-04 12:51 ` Daniel P. Berrangé
2023-10-04 13:41 ` Claudio Fontana
2023-10-04 13:49 ` Paolo Bonzini
2023-10-04 13:53 ` Daniel P. Berrangé
2023-10-06 7:49 ` Thomas Huth
2023-10-04 14:06 ` Philippe Mathieu-Daudé [this message]
2023-10-04 13:20 ` Paolo Bonzini
2023-10-04 13:26 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=191a6af3-489b-04bc-0afb-092bdb437a47@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=cfontana@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).