From: Collin Walling <walling@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Pierre Morel <pmorel@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 1/6] s390x/pci: Fix primary bus number for PCI bridges
Date: Mon, 4 Feb 2019 17:58:18 -0500 [thread overview]
Message-ID: <191e8d6f-31a7-93bd-376c-783a9dde90ba@linux.ibm.com> (raw)
In-Reply-To: <20190130155733.32742-2-david@redhat.com>
On 1/30/19 10:57 AM, David Hildenbrand wrote:
> The primary bus number corresponds always to the bus number of the
> bus the bridge is attached to.
>
> Right now, if we have two bridges attached to the same bus (e.g. root
> bus) this is however not the case. The first bridge will have primary
> bus 0, the second bridge primary bus 1, which is wrong. Fix the assignment.
>
> While at it, drop setting the PCI_SUBORDINATE_BUS temporarily to 0xff.
> Setting it temporarily to that value (as discussed e.g. in [1]), is
> only relevant for a running system that probes the buses. The value is
> effectively unused for us just doing a DFS.
>
> Also add a comment why we have to reassign during every reset (which I
> found to be surprising.
>
> Please note that hotplugging of bridges is in general still broken, will
> be fixed next.
>
> [1] http://www.science.unitn.it/~fiorella/guidelinux/tlk/node76.html
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
Reviewed-by: Collin Walling <walling@linux.ibm.com>
next prev parent reply other threads:[~2019-02-04 22:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 15:57 [Qemu-devel] [PATCH v2 0/6] s390x/pci: remaining hot/un)plug patches David Hildenbrand
2019-01-30 15:57 ` [Qemu-devel] [PATCH v2 1/6] s390x/pci: Fix primary bus number for PCI bridges David Hildenbrand
2019-02-04 22:58 ` Collin Walling [this message]
2019-01-30 15:57 ` [Qemu-devel] [PATCH v2 2/6] s390x/pci: Fix hotplugging of " David Hildenbrand
2019-02-04 22:48 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-02-04 23:43 ` David Hildenbrand
2019-02-05 9:24 ` Cornelia Huck
2019-01-30 15:57 ` [Qemu-devel] [PATCH v2 3/6] s390x/pci: Warn when adding PCI devices without the 'zpci' feature David Hildenbrand
2019-02-04 20:19 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-02-04 21:54 ` David Hildenbrand
2019-02-04 22:42 ` Collin Walling
2019-02-04 22:45 ` David Hildenbrand
2019-02-05 9:32 ` Cornelia Huck
2019-01-30 15:57 ` [Qemu-devel] [PATCH v2 4/6] s390x/pci: Introduce unplug requests and split unplug handler David Hildenbrand
2019-01-31 20:40 ` Collin Walling
2019-01-31 21:11 ` David Hildenbrand
2019-02-01 10:38 ` Cornelia Huck
2019-01-30 15:57 ` [Qemu-devel] [PATCH v2 5/6] s390x/pci: Drop release timer and replace it with a flag David Hildenbrand
2019-01-31 20:33 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-01-31 21:12 ` David Hildenbrand
2019-01-31 21:21 ` [Qemu-devel] " David Hildenbrand
2019-02-01 10:08 ` Cornelia Huck
2019-02-01 10:37 ` David Hildenbrand
2019-02-01 10:42 ` Cornelia Huck
2019-02-01 10:39 ` Cornelia Huck
2019-01-30 15:57 ` [Qemu-devel] [PATCH v2 6/6] s390x/pci: Unplug remaining requested devices on pcihost reset David Hildenbrand
2019-01-31 20:26 ` Collin Walling
2019-01-31 21:13 ` David Hildenbrand
2019-02-01 10:19 ` Cornelia Huck
2019-02-01 15:06 ` David Hildenbrand
2019-02-05 9:35 ` Cornelia Huck
2019-01-30 16:27 ` [Qemu-devel] [PATCH v2 0/6] s390x/pci: remaining hot/un)plug patches Cornelia Huck
2019-01-31 20:43 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-01-31 21:21 ` David Hildenbrand
2019-02-01 8:35 ` Cornelia Huck
2019-02-01 9:18 ` David Hildenbrand
2019-02-01 15:44 ` Collin Walling
2019-02-05 9:55 ` [Qemu-devel] " Cornelia Huck
2019-02-05 9:55 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=191e8d6f-31a7-93bd-376c-783a9dde90ba@linux.ibm.com \
--to=walling@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).