From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2rDQ-0001Fa-R2 for qemu-devel@nongnu.org; Mon, 24 Apr 2017 23:32:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2rDN-0004QU-N9 for qemu-devel@nongnu.org; Mon, 24 Apr 2017 23:32:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43410) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2rDN-0004Pr-EF for qemu-devel@nongnu.org; Mon, 24 Apr 2017 23:32:33 -0400 References: <20170424153244.2600-1-dgilbert@redhat.com> <20170424165723.GK2362@work-vm> From: Thomas Huth Message-ID: <194bfbef-efad-0f2e-457c-84533e66fdb5@redhat.com> Date: Tue, 25 Apr 2017 05:32:26 +0200 MIME-Version: 1.0 In-Reply-To: <20170424165723.GK2362@work-vm> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 0/4] hmp queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Peter Maydell Cc: QEMU Developers , Paolo Bonzini On 24.04.2017 18:57, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.maydell@linaro.org) wrote: >> On 24 April 2017 at 16:32, Dr. David Alan Gilbert (git) >> wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> The following changes since commit 4c55b1d0bad8a703f0499fe62e3761a0cd288da3: >>> >>> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2017-04-24' into staging (2017-04-24 14:49:48 +0100) >>> >>> are available in the git repository at: >>> >>> git://github.com/dagrh/qemu.git tags/pull-hmp-20170424 >>> >>> for you to fetch changes up to e4e3992e626c4cc7514b271807c90f587771c646: >>> >>> tests: Add a tester for HMP commands (2017-04-24 15:55:35 +0100) >>> >>> ---------------------------------------------------------------- >>> HMP pull >>> >>> ---------------------------------------------------------------- >> >> >> clang doesn't like some code in test-hmp.c: >> >> /home/petmay01/linaro/qemu-for-merges/tests/test-hmp.c:138:9: error: >> logical not is only applied to the left hand side of this comparison >> [-Werror,-Wlogical-not-parentheses] >> if (!strcmp("isapc", mname) == 0 || !strcmp("puv3", mname) >> ^ ~~ > > > >> It does look rather odd: >> >> + /* Ignore blacklisted machines that have known problems */ >> + if (!strcmp("isapc", mname) == 0 || !strcmp("puv3", mname) >> + || !strcmp("tricore_testboard", mname) >> + || !strcmp("xenfv", mname) == 0 || !strcmp("xenpv", mname)) { >> + return; >> + } >> >> since it's not using the same kind of expression to test >> each board name -- is that deliberate, or accidental ? >> >> I think this expression means we'll actually skip every machine... > > Yep, you're right, just tried it with logging. Ouch, not sure how that happened ... looks like I used "strcmp("isapc", mname) == 0" in the first version of my patch, and then wanted to switch to "!strcmp()" when I added the xenfv and xenpv machines, but forgot to remove the "== 0" everywhere :-( Big sorry for that mess! > That's accidental; hmm I should add a clang build somewhere. > > Thomas: Do you want to send me a fixed version? Yes, I'll send a fixed version, where I also correct the memory leak that you noticed. Thomas