From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, crobinso@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH 2/3] qemu/atomic: Use macros for CONFIG_ATOMIC64
Date: Mon, 12 Jul 2021 18:29:39 +0200 [thread overview]
Message-ID: <1952860a-2ee1-f5c7-b242-39044096d667@redhat.com> (raw)
In-Reply-To: <20210712155918.1422519-3-richard.henderson@linaro.org>
On 7/12/21 5:59 PM, Richard Henderson wrote:
> Clang warnings about questionable atomic usage get localized
> to the inline function in atomic.h. By using a macro, we get
> the full traceback to the original use that caused the warning.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/qemu/atomic.h | 25 +++++--------------------
> 1 file changed, 5 insertions(+), 20 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-07-12 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 15:59 [PATCH 0/3] Atomic cleanup + clang-12 build fix Richard Henderson
2021-07-12 15:59 ` [PATCH 1/3] qemu/atomic: Remove pre-C11 atomic fallbacks Richard Henderson
2021-07-12 15:59 ` [PATCH 2/3] qemu/atomic: Use macros for CONFIG_ATOMIC64 Richard Henderson
2021-07-12 16:29 ` Philippe Mathieu-Daudé [this message]
2021-07-12 15:59 ` [PATCH 3/3] configure: Conditionally disable clang-12 -Watomic-alignment Richard Henderson
2021-07-12 21:30 ` [PATCH 0/3] Atomic cleanup + clang-12 build fix Cole Robinson
2021-07-13 0:37 ` Richard Henderson
2021-07-13 14:43 ` Richard Henderson
2021-07-13 15:18 ` Cole Robinson
2021-07-13 16:56 ` Richard Henderson
2021-07-15 15:11 ` Cole Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1952860a-2ee1-f5c7-b242-39044096d667@redhat.com \
--to=philmd@redhat.com \
--cc=crobinso@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).