From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWk6R-0002OJ-1I for qemu-devel@nongnu.org; Thu, 26 Jan 2017 08:28:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWk6N-00086Q-T5 for qemu-devel@nongnu.org; Thu, 26 Jan 2017 08:28:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37010) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWk6N-00086H-NN for qemu-devel@nongnu.org; Thu, 26 Jan 2017 08:28:35 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C60DB61B9A for ; Thu, 26 Jan 2017 13:28:35 +0000 (UTC) References: <1485436265-12573-1-git-send-email-thuth@redhat.com> <1485436265-12573-6-git-send-email-thuth@redhat.com> From: Paolo Bonzini Message-ID: <195c3d94-9a9c-6e48-954c-b2769691929e@redhat.com> Date: Thu, 26 Jan 2017 14:28:32 +0100 MIME-Version: 1.0 In-Reply-To: <1485436265-12573-6-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 5/5] checkpatch: reduce MAINTAINERS update message frequency List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org, Markus Armbruster On 26/01/2017 14:11, Thomas Huth wrote: > This is a port of the following commit from the Linux kernel: > > commit e0d975b1b439c4fef58fbc306c542c94f48bb849 > Author: Joe Perches > Date: Wed Dec 10 15:51:49 2014 -0800 > > checkpatch: reduce MAINTAINERS update message frequency > > When files are being added/moved/deleted and a patch contains an update to > the MAINTAINERS file, assume it's to update the MAINTAINERS file correctly > and do not emit the "does MAINTAINERS need updating?" message. > > Reported by many people. > > Signed-off-by: Joe Perches > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > > Signed-off-by: Thomas Huth > --- > scripts/checkpatch.pl | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index e1be7b3..555a5b6 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1300,6 +1300,12 @@ sub process { > } > } > > +# Check if MAINTAINERS is being updated. If so, there's probably no need to > +# emit the "does MAINTAINERS need updating?" message on file add/move/delete > + if ($line =~ /^\s*MAINTAINERS\s*\|/) { > + $reported_maintainer_file = 1; > + } > + > # Check for added, moved or deleted files > if (!$reported_maintainer_file && !$in_commit_log && > ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ || > Maybe leave it as a warning given this change? Paolo