From: Cleber Rosa <crosa@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/9] iotests: Use // for Python integer division
Date: Fri, 19 Oct 2018 20:19:27 -0400 [thread overview]
Message-ID: <19756270-c1f7-bd24-fab6-d30c719da5d3@redhat.com> (raw)
In-Reply-To: <20181019191523.12157-5-mreitz@redhat.com>
On 10/19/18 3:15 PM, Max Reitz wrote:
> In Python 3, / is always a floating-point division. We usually do not
> want this, and as Python 2.7 understands // as well, change all integer
> divisions to use that.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
next prev parent reply other threads:[~2018-10-20 0:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 19:15 [Qemu-devel] [PATCH v2 0/9] iotests: Make them work for both Python 2 and 3 Max Reitz
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 1/9] iotests: Make nbd-fault-injector flush Max Reitz
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 2/9] iotests: Flush in iotests.py's QemuIoInteractive Max Reitz
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 3/9] iotests: Use Python byte strings where appropriate Max Reitz
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 4/9] iotests: Use // for Python integer division Max Reitz
2018-10-19 20:01 ` Eduardo Habkost
2018-10-20 0:19 ` Cleber Rosa [this message]
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 5/9] iotests: Different iterator behavior in Python 3 Max Reitz
2018-10-19 20:01 ` Eduardo Habkost
2018-10-20 0:53 ` Cleber Rosa
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 6/9] iotests: Explicitly inherit FDs in Python Max Reitz
2018-10-19 20:07 ` Eduardo Habkost
2018-10-20 0:54 ` Cleber Rosa
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 7/9] iotests: 'new' module replacement in 169 Max Reitz
2018-10-20 0:54 ` Cleber Rosa
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 8/9] iotests: Modify imports for Python 3 Max Reitz
2018-10-19 20:11 ` Eduardo Habkost
2018-10-20 0:58 ` Cleber Rosa
2018-10-19 19:15 ` [Qemu-devel] [PATCH v2 9/9] iotests: Unify log outputs between Python 2 and 3 Max Reitz
2018-10-20 0:59 ` Cleber Rosa
2018-10-20 1:00 ` [Qemu-devel] [PATCH v2 0/9] iotests: Make them work for both " Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19756270-c1f7-bd24-fab6-d30c719da5d3@redhat.com \
--to=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).