From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [PATCH 4/5] hw/i386/pc: Inline i8042_setup_a20_line() and remove it
Date: Tue, 20 Feb 2024 08:23:58 +0100 [thread overview]
Message-ID: <197fa809-71f6-4cbf-b062-0edef3df36f7@linaro.org> (raw)
In-Reply-To: <20240218131701.91132-5-shentey@gmail.com>
On 18/2/24 14:17, Bernhard Beschow wrote:
> This function is used once in the pc machines. Remove it since it contains one
> line only.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> include/hw/input/i8042.h | 1 -
> hw/i386/pc.c | 2 +-
> hw/input/pckbd.c | 5 -----
> 3 files changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-02-20 7:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 13:16 [PATCH 0/5] Implement port 92 in south bridges Bernhard Beschow
2024-02-18 13:16 ` [PATCH 1/5] hw/isa/meson.build: Sort alphabetically Bernhard Beschow
2024-02-20 7:21 ` Philippe Mathieu-Daudé
2024-02-21 11:42 ` Mark Cave-Ayland
2024-02-18 13:16 ` [PATCH 2/5] hw/i386/port92: Allow for TYPE_PORT92 to be embedded in devices Bernhard Beschow
2024-02-21 11:43 ` Mark Cave-Ayland
2024-02-18 13:16 ` [PATCH 3/5] hw/isa: Embed TYPE_PORT92 in south bridges used in PC machines Bernhard Beschow
2024-02-21 11:53 ` Mark Cave-Ayland
2024-02-21 12:23 ` BALATON Zoltan
2024-02-27 19:20 ` Bernhard Beschow
2024-02-27 21:54 ` BALATON Zoltan
2024-02-27 23:34 ` Bernhard Beschow
2024-02-28 0:30 ` BALATON Zoltan
2024-02-28 13:02 ` BALATON Zoltan
2024-03-02 12:14 ` Bernhard Beschow
2024-03-02 12:38 ` BALATON Zoltan
2024-02-18 13:17 ` [PATCH 4/5] hw/i386/pc: Inline i8042_setup_a20_line() and remove it Bernhard Beschow
2024-02-20 7:23 ` Philippe Mathieu-Daudé [this message]
2024-02-21 17:37 ` Philippe Mathieu-Daudé
2024-02-18 13:17 ` [PATCH 5/5] hw/isa/vt82c686: Embed TYPE_PORT92 Bernhard Beschow
2024-02-18 16:12 ` [PATCH 0/5] Implement port 92 in south bridges BALATON Zoltan
2024-02-19 22:42 ` Bernhard Beschow
2024-03-12 15:47 ` Michael S. Tsirkin
2024-03-13 10:09 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=197fa809-71f6-4cbf-b062-0edef3df36f7@linaro.org \
--to=philmd@linaro.org \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=eduardo@habkost.net \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).