From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54668)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bCvhX-0005sT-FX
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 17:16:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bCvhT-0003cj-AB
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 17:16:46 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:57464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bCvhT-0003cS-21
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 17:16:43 -0400
Date: Tue, 14 Jun 2016 17:16:40 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1990888058.22417362.1465939000140.JavaMail.zimbra@redhat.com>
In-Reply-To: <1465937948-548-11-git-send-email-ehabkost@redhat.com>
References: <1465937948-548-1-git-send-email-ehabkost@redhat.com>
	<1465937948-548-11-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings
 if +-features are used
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>, qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>, Igor Mammedov <imammedo@redhat.com>



----- Original Message -----
> From: "Eduardo Habkost" <ehabkost@redhat.com>
> To: "Peter Maydell" <peter.maydell@linaro.org>
> Cc: "Andreas F=C3=A4rber" <afaerber@suse.de>, qemu-devel@nongnu.org, "Ric=
hard Henderson" <rth@twiddle.net>, "Paolo
> Bonzini" <pbonzini@redhat.com>, "Igor Mammedov" <imammedo@redhat.com>
> Sent: Tuesday, June 14, 2016 10:59:08 PM
> Subject: [PULL 10/10] target-i386: Print obsolete warnings if +-features =
are used
>=20
> From: Igor Mammedov <imammedo@redhat.com>
>=20
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> [ehabkost: Changed to use error_report()]
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 3665fec..baa3783 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1980,9 +1980,15 @@ static void x86_cpu_parse_featurestr(CPUState *cs,
> char *features,
>          /* Compatibility syntax: */
>          if (featurestr[0] =3D=3D '+') {
>              add_flagname_to_bitmaps(featurestr + 1, plus_features,
>              &local_err);
> +            error_report(
> +                "'+%s' is obsolete and will be removed in future, use
> '%s=3Don'",
> +                featurestr + 1, featurestr + 1);
>              continue;
>          } else if (featurestr[0] =3D=3D '-') {
>              add_flagname_to_bitmaps(featurestr + 1, minus_features,
>              &local_err);
> +            error_report(
> +                "'-%s' is obsolete and will be removed in future, use
> '%s=3Doff'",
> +                featurestr + 1, featurestr + 1);
>              continue;
>          }

I still disagree with this change.

Paolo