From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1AA6C4345F for ; Thu, 11 Apr 2024 20:44:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rv1Go-0004bB-Qn; Thu, 11 Apr 2024 16:43:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rv1Gn-0004a4-7r for qemu-devel@nongnu.org; Thu, 11 Apr 2024 16:43:41 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rv1Gh-0003hk-9p for qemu-devel@nongnu.org; Thu, 11 Apr 2024 16:43:40 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-417d029bee7so1952325e9.1 for ; Thu, 11 Apr 2024 13:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712868213; x=1713473013; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3R+9PPXbgndEwnQH8HX9TDe924s15k6ehg57WOhAWgs=; b=vJ1gX7N/XcQiknOOQswz/TTJ/bkNChvBjKu86gZe+/V7TEi29WbJfJttj+HhYYC52O ZI9IGc5kHzomIOjxpgslU0XJ/ERxopyrzzObWFa0jjcXMKt4hy2dfqmyjkhkpB9cH7OM LKJDAJy4sSp9BWz18VIFtLQfHkupYqO2DyypWWX3pAv/Y5WGdkNPc3lWGhIE9zOfctYe 7XyAr3/exZS33yLnk4qQthm6dpYo79w2WsVBsZ2ZIap8+1TZx49ocTcXquUtoi3vi0q2 4qaMczfpL28YHRTqmdl/okOBi1dbUoYR13aVU261w+LQoPgqAOKU+yvSpr2sarlVzeJh hc6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712868213; x=1713473013; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3R+9PPXbgndEwnQH8HX9TDe924s15k6ehg57WOhAWgs=; b=QA/W5CdiguPiQBdCTloQ9xs0x7t2OTXagDPFIQ5avOubwQ3tJlTVQfSHADiwzgafwz DBTZtRJAmrQX4xdcGaXAsbw4tCOM63U9sfV908gjTGR5+LgnMuk4icKvyqUISWLPdH4E oR3DzVJ8UzSyNf8UC893MsuMTl2IsPXrTemsYRfiKQtIMlEVUNGOG13yMh50gfomGTko zNz8Vzi8a0wX/kaQa/PLwCimssDDiwV/rPCsIQ9bTIPm9WpBFYSynHZDtNzdBL7fifV2 IlbThA0RA9JYCQ3d+zPyyaMLHWNzpX6aOnhMKYepQ4JEcRsfLVUR9892vIbDqKxeGFU/ IsDw== X-Gm-Message-State: AOJu0YxyJ6OywuMOwDy9/mjN7kACQuGwlqK44K5EUJO9AHJUJ4vu2nz0 jM8emMLfCK++7xAKMa7VaevOr6TtFr/OvMpf5dbXDHxcUg0AyMs+buUf/x1k3bifQcaywgWuFy3 rsUs= X-Google-Smtp-Source: AGHT+IHFuobM9C0yTEdw8JlxBul/hXvnV3DufmxwNNefCULHctJHcnXpKREA464CWUCB+zX6AvsIDQ== X-Received: by 2002:a5d:6583:0:b0:343:7b6b:dcc6 with SMTP id q3-20020a5d6583000000b003437b6bdcc6mr447581wru.30.1712868213088; Thu, 11 Apr 2024 13:43:33 -0700 (PDT) Received: from [192.168.1.28] (lfbn-bay-1-170-196.w83-193.abo.wanadoo.fr. [83.193.250.196]) by smtp.gmail.com with ESMTPSA id k5-20020a5d66c5000000b00346406a5c80sm2549238wrw.32.2024.04.11.13.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 13:43:32 -0700 (PDT) Message-ID: <19938e9b-ddd0-4dfe-a75f-f4ad0f281a85@linaro.org> Date: Thu, 11 Apr 2024 22:43:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/13] util/hexdump: Replace sprintf() by g_string_append_printf() To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-ppc@nongnu.org References: <20240411101550.99392-1-philmd@linaro.org> <20240411101550.99392-10-philmd@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20240411101550.99392-10-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/4/24 12:15, Philippe Mathieu-Daudé wrote: > sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, > resulting in painful developper experience. > > Replace sprintf() by GString API in order to avoid: > > [426/1310] Compiling C object libqemuutil.a.p/util_hexdump.c.o > util/hexdump.c:35:21: warning: 'sprintf' is deprecated: > This function is provided for compatibility reasons only. > Due to security concerns inherent in the design of sprintf(3), > it is highly recommended that you use snprintf(3) instead. > [-Wdeprecated-declarations] > line += sprintf(line, " %02x", (unsigned char)buf[b + i]); > ^ > util/hexdump.c:37:21: warning: 'sprintf' is deprecated: > line += sprintf(line, " "); > ^ > 2 warnings generated. > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/hexdump.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/util/hexdump.c b/util/hexdump.c > index b6f70e93bb..2ec1171de3 100644 > --- a/util/hexdump.c > +++ b/util/hexdump.c > @@ -19,7 +19,7 @@ > char *qemu_hexdump_line(const void *bufptr, unsigned offset, > unsigned int len, bool ascii) > { > - char linebuf[QEMU_HEXDUMP_LINE_BYTES], *line = linebuf; > + g_autoptr(GString) gs = g_string_sized_new(QEMU_HEXDUMP_LINE_BYTES); > const char *buf = bufptr; > int i, c; > > @@ -27,30 +27,29 @@ char *qemu_hexdump_line(const void *bufptr, unsigned offset, > len = QEMU_HEXDUMP_LINE_BYTES; > } > > - line += snprintf(line, 6, "%04x:", offset); > + g_string_append_printf(gs, "%04x:", offset); > for (i = 0; i < QEMU_HEXDUMP_LINE_BYTES; i++) { > if ((i % 4) == 0) { > - *line++ = ' '; > + g_string_append_c(gs, ' '); > } > if (i < len) { > - line += sprintf(line, " %02x", (unsigned char)buf[offset + i]); > + g_string_append_printf(gs, " %02x", (unsigned char)buf[offset + i]); I find using g_string_append_printf() simpler than checking snprintf() return value, and don't expect this function to be in hot path, but if preferred I can try to not use the GString API. > } else { > - line += sprintf(line, " "); > + g_string_append(gs, " "); > } > }