* [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386
@ 2012-11-28 9:16 Alon Levy
2012-11-28 9:16 ` [Qemu-devel] [PATCH 2/2] libcacard: fix missing symbol in libcacard.so Alon Levy
2012-11-28 9:36 ` [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386 Paolo Bonzini
0 siblings, 2 replies; 6+ messages in thread
From: Alon Levy @ 2012-11-28 9:16 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Alon Levy <alevy@redhat.com>
---
libcacard/Makefile | 4 ++--
roms/openbios | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index c26aac6..25bc4a0 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -15,7 +15,7 @@ QEMU_CFLAGS+=-I../
libcacard.lib-y=$(patsubst %.o,%.lo,$(libcacard-y))
vscclient: $(libcacard-y) $(QEMU_OBJS) vscclient.o cutils.o
- $(call quiet-command,$(CC) -o $@ $^ $(libcacard_libs) $(LIBS)," LINK $@")
+ $(call quiet-command,$(CC) -o $@ $^ $(libcacard_libs) $(LDFLAGS) $(LIBS)," LINK $@")
clean:
rm -f *.o */*.o *.d */*.d *.a */*.a *~ */*~ vscclient *.lo */*.lo .libs/* */.libs/* *.la */*.la *.pc
@@ -36,7 +36,7 @@ install-libcacard:
@echo "libtool is missing, please install and rerun configure"; exit 1
else
libcacard.la: $(libcacard.lib-y) $(QEMU_OBJS_LIB)
- $(call quiet-command,$(LIBTOOL) --mode=link --quiet --tag=CC $(CC) -rpath $(libdir) -o $@ $^ $(libcacard_libs)," lt LINK $@")
+ $(call quiet-command,$(LIBTOOL) --mode=link --quiet --tag=CC $(CC) $(LDFLAGS) -rpath $(libdir) -o $@ $^ $(libcacard_libs)," lt LINK $@")
libcacard_srcpath=$(SRC_PATH)/libcacard
libcacard.pc: $(libcacard_srcpath)/libcacard.pc.in
diff --git a/roms/openbios b/roms/openbios
index f095c85..d1d2787 160000
--- a/roms/openbios
+++ b/roms/openbios
@@ -1 +1 @@
-Subproject commit f095c858136896d236931357b8d597f407286f71
+Subproject commit d1d2787f87167edf487a60e61b9168514d5a7434
--
1.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH 2/2] libcacard: fix missing symbol in libcacard.so
2012-11-28 9:16 [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386 Alon Levy
@ 2012-11-28 9:16 ` Alon Levy
2012-11-28 9:36 ` [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386 Paolo Bonzini
1 sibling, 0 replies; 6+ messages in thread
From: Alon Levy @ 2012-11-28 9:16 UTC (permalink / raw)
To: qemu-devel
Before patch:
$ make libcacard.la
$ nm ./libcacard/.libs/libcacard.so.0.0.0 | grep " U " | \
egrep -v "(g_)|(GLIBC)|(SECMOD)|(PK11)|(CERT)|(NSS)|(PORT)|(PR)"
U error_set
Signed-off-by: Alon Levy <alevy@redhat.com>
---
libcacard/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 25bc4a0..7bce286 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -7,7 +7,7 @@ libcacard_includedir=$(includedir)/cacard
$(call set-vpath, $(SRC_PATH))
# objects linked into a shared library, built with libtool with -fPIC if required
-QEMU_OBJS=$(oslib-obj-y) qemu-timer-common.o $(trace-obj-y) $(stub-obj-y)
+QEMU_OBJS=$(oslib-obj-y) qemu-timer-common.o error.o $(trace-obj-y) $(stub-obj-y)
QEMU_OBJS_LIB=$(patsubst %.o,%.lo,$(QEMU_OBJS))
QEMU_CFLAGS+=-I../
--
1.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386
2012-11-28 9:16 [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386 Alon Levy
2012-11-28 9:16 ` [Qemu-devel] [PATCH 2/2] libcacard: fix missing symbol in libcacard.so Alon Levy
@ 2012-11-28 9:36 ` Paolo Bonzini
2012-11-28 9:53 ` Alon Levy
1 sibling, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2012-11-28 9:36 UTC (permalink / raw)
To: Alon Levy; +Cc: qemu-devel
Il 28/11/2012 10:16, Alon Levy ha scritto:
> diff --git a/roms/openbios b/roms/openbios
> index f095c85..d1d2787 160000
> --- a/roms/openbios
> +++ b/roms/openbios
> @@ -1 +1 @@
> -Subproject commit f095c858136896d236931357b8d597f407286f71
> +Subproject commit d1d2787f87167edf487a60e61b9168514d5a7434
This is probably unwanted.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386
2012-11-28 9:36 ` [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386 Paolo Bonzini
@ 2012-11-28 9:53 ` Alon Levy
2012-12-19 8:33 ` Paolo Bonzini
0 siblings, 1 reply; 6+ messages in thread
From: Alon Levy @ 2012-11-28 9:53 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
> Il 28/11/2012 10:16, Alon Levy ha scritto:
> > diff --git a/roms/openbios b/roms/openbios
> > index f095c85..d1d2787 160000
> > --- a/roms/openbios
> > +++ b/roms/openbios
> > @@ -1 +1 @@
> > -Subproject commit f095c858136896d236931357b8d597f407286f71
> > +Subproject commit d1d2787f87167edf487a60e61b9168514d5a7434
>
> This is probably unwanted.
Yes, my bad. I'll drop it in the pull request.
>
> Paolo
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386
2012-11-28 9:53 ` Alon Levy
@ 2012-12-19 8:33 ` Paolo Bonzini
2012-12-23 20:35 ` Alon Levy
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2012-12-19 8:33 UTC (permalink / raw)
To: Alon Levy; +Cc: qemu-devel
Il 28/11/2012 10:53, Alon Levy ha scritto:
>> Il 28/11/2012 10:16, Alon Levy ha scritto:
>>> > > diff --git a/roms/openbios b/roms/openbios
>>> > > index f095c85..d1d2787 160000
>>> > > --- a/roms/openbios
>>> > > +++ b/roms/openbios
>>> > > @@ -1 +1 @@
>>> > > -Subproject commit f095c858136896d236931357b8d597f407286f71
>>> > > +Subproject commit d1d2787f87167edf487a60e61b9168514d5a7434
>> >
>> > This is probably unwanted.
> Yes, my bad. I'll drop it in the pull request.
>
Are you going to send it soon?
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386
2012-12-19 8:33 ` Paolo Bonzini
@ 2012-12-23 20:35 ` Alon Levy
0 siblings, 0 replies; 6+ messages in thread
From: Alon Levy @ 2012-12-23 20:35 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Wed, Dec 19, 2012 at 09:33:28AM +0100, Paolo Bonzini wrote:
> Il 28/11/2012 10:53, Alon Levy ha scritto:
> >> Il 28/11/2012 10:16, Alon Levy ha scritto:
> >>> > > diff --git a/roms/openbios b/roms/openbios
> >>> > > index f095c85..d1d2787 160000
> >>> > > --- a/roms/openbios
> >>> > > +++ b/roms/openbios
> >>> > > @@ -1 +1 @@
> >>> > > -Subproject commit f095c858136896d236931357b8d597f407286f71
> >>> > > +Subproject commit d1d2787f87167edf487a60e61b9168514d5a7434
> >> >
> >> > This is probably unwanted.
> > Yes, my bad. I'll drop it in the pull request.
> >
>
> Are you going to send it soon?
I didn't manage to do this, I guess your new series includes this? I'll
try to review it.
>
> Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-23 20:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-28 9:16 [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386 Alon Levy
2012-11-28 9:16 ` [Qemu-devel] [PATCH 2/2] libcacard: fix missing symbol in libcacard.so Alon Levy
2012-11-28 9:36 ` [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386 Paolo Bonzini
2012-11-28 9:53 ` Alon Levy
2012-12-19 8:33 ` Paolo Bonzini
2012-12-23 20:35 ` Alon Levy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).