From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Enforce multiline comment syntax
Date: Thu, 9 Aug 2018 18:43:20 +0200 [thread overview]
Message-ID: <19a9c0c6-03eb-d368-d8c8-fb62102556a4@redhat.com> (raw)
In-Reply-To: <20180809160011.17225-1-peter.maydell@linaro.org>
On 09/08/2018 18:00, Peter Maydell wrote:
> The kernel's checkpatch does not enforce "leading /* on
> a line of its own, so that part is unique to QEMU's checkpatch.
Yeah, that's because for some reason the Linux network subsystem uses
the style without the lone leading "/*". Which is actually what QEMU is
using in most of the code, I think, so...
> I'm still not used to the leeading-/*-on-it's-own style,
> so having checkpatch catch my lapses is handy...
... if it's not what we are using, why enforce it?
Paolo
next prev parent reply other threads:[~2018-08-09 16:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 16:00 [Qemu-devel] [PATCH] scripts/checkpatch.pl: Enforce multiline comment syntax Peter Maydell
2018-08-09 16:43 ` Paolo Bonzini [this message]
2018-08-09 17:03 ` Peter Maydell
2018-08-10 8:34 ` Paolo Bonzini
2018-08-10 9:10 ` Peter Maydell
2018-08-10 12:45 ` Paolo Bonzini
2018-08-10 12:53 ` Peter Maydell
2018-08-10 17:06 ` Paolo Bonzini
2018-08-13 6:18 ` Thomas Huth
2018-08-13 8:01 ` Paolo Bonzini
2018-08-10 9:41 ` Markus Armbruster
2018-08-10 12:44 ` Paolo Bonzini
2018-08-10 13:19 ` Markus Armbruster
2018-08-10 6:22 ` Markus Armbruster
2018-08-10 9:07 ` Peter Maydell
2018-08-10 12:08 ` Markus Armbruster
2018-08-13 6:26 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19a9c0c6-03eb-d368-d8c8-fb62102556a4@redhat.com \
--to=pbonzini@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).