From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Alberto Garcia <berto@igalia.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v3 3/7] qapi: Replace qobject_to_X(o) by qobject_to(o, X)
Date: Sat, 10 Mar 2018 15:48:00 -0600 [thread overview]
Message-ID: <19bb0fb0-6e9c-97aa-f4fb-c619ffabde87@redhat.com> (raw)
In-Reply-To: <8b6cb74b-6335-3ee2-0dc3-ff5604704608@redhat.com>
On 02/28/2018 12:08 PM, Max Reitz wrote:
>>>>> + options = qobject_to(options_obj, QDict);
>>>>
>>>> Bikeshedding - would it read any easier as:
>>>>
>>>> options = qobject_to(QDict, options_obj);
>>>>
>> So at this point, I'm 70:30 in favor of doing the rename to have
>> qobject_to(type, obj) for consistency with majority of other macros that
>> take a type name (type names are already unusual as arguments to macros,
>> whether or not the macro is named with ALL_CAPS). (Sorry, I know that
>> means more busy work for you, if you agree with my reasoning)
>
> I agree, because it means I have a decision. :-)
Are you planning on posting a v4, or shall I go ahead and make the swap
as part of staging this on my QAPI tree?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-10 21:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 15:40 [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link Max Reitz
2018-02-24 15:40 ` [Qemu-devel] [PATCH v3 1/7] compiler: Add QEMU_BUILD_BUG_MSG() macro Max Reitz
2018-02-24 20:08 ` Eric Blake
2018-02-27 13:33 ` Alberto Garcia
2018-02-24 15:40 ` [Qemu-devel] [PATCH v3 2/7] qapi: Add qobject_to() Max Reitz
2018-02-24 20:57 ` Eric Blake
2018-02-26 11:58 ` Max Reitz
2018-03-19 19:36 ` Eric Blake
2018-03-19 19:38 ` Max Reitz
2018-02-27 13:45 ` Alberto Garcia
2018-02-24 15:40 ` [Qemu-devel] [PATCH v3 3/7] qapi: Replace qobject_to_X(o) by qobject_to(o, X) Max Reitz
2018-02-24 21:04 ` Eric Blake
2018-02-26 12:01 ` Max Reitz
2018-02-27 14:47 ` Eric Blake
2018-02-28 18:08 ` Max Reitz
2018-03-10 21:48 ` Eric Blake [this message]
2018-02-24 15:40 ` [Qemu-devel] [PATCH v3 4/7] qapi: Remove qobject_to_X() functions Max Reitz
2018-02-24 21:05 ` Eric Blake
2018-02-24 15:40 ` [Qemu-devel] [PATCH v3 5/7] qapi: Make more of qobject_to() Max Reitz
2018-02-24 21:07 ` Eric Blake
2018-02-24 15:40 ` [Qemu-devel] [PATCH v3 6/7] block: Handle null backing link Max Reitz
2018-02-24 21:09 ` Eric Blake
2018-02-24 15:40 ` [Qemu-devel] [PATCH v3 7/7] block: Deprecate "backing": "" Max Reitz
2018-02-24 18:02 ` [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link no-reply
2018-02-26 11:50 ` Max Reitz
2018-02-24 19:51 ` no-reply
2018-02-24 20:19 ` no-reply
2018-02-24 20:30 ` no-reply
2018-02-25 23:38 ` no-reply
2018-02-26 6:11 ` no-reply
2018-03-09 20:11 ` Eric Blake
2018-03-10 22:34 ` Eric Blake
2018-03-12 12:22 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19bb0fb0-6e9c-97aa-f4fb-c619ffabde87@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).