From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] tcg: Unify TCG_TARGET_HAS_extr[lh]_i64_i32
Date: Wed, 23 Aug 2023 00:05:46 +0200 [thread overview]
Message-ID: <19bce54d-5e47-e0f9-e804-434ef99839fc@linaro.org> (raw)
In-Reply-To: <20230822175127.1173698-1-richard.henderson@linaro.org>
On 22/8/23 19:51, Richard Henderson wrote:
> Replace the separate defines with TCG_TARGET_HAS_extr_i64_i32,
> so that the two parts of backend-specific type changing cannot
> be out of sync.
>
> Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/tcg/tcg-opc.h | 4 ++--
> include/tcg/tcg.h | 3 +--
> tcg/aarch64/tcg-target.h | 3 +--
> tcg/i386/tcg-target.h | 3 +--
> tcg/loongarch64/tcg-target.h | 3 +--
> tcg/mips/tcg-target.h | 3 +--
> tcg/ppc/tcg-target.h | 3 +--
> tcg/riscv/tcg-target.h | 3 +--
> tcg/s390x/tcg-target.h | 3 +--
> tcg/sparc64/tcg-target.h | 3 +--
> tcg/tci/tcg-target.h | 3 +--
> tcg/tcg-op.c | 4 ++--
> tcg/tcg.c | 3 +--
> 13 files changed, 15 insertions(+), 26 deletions(-)
Clever than what I was thinking of, thanks!
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-08-22 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 17:51 [PATCH] tcg: Unify TCG_TARGET_HAS_extr[lh]_i64_i32 Richard Henderson
2023-08-22 22:05 ` Philippe Mathieu-Daudé [this message]
2023-08-22 23:09 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19bce54d-5e47-e0f9-e804-434ef99839fc@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).