From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PULL 3/5] hmp-commands-info: Fix "info rocker-FOO" misspellings
Date: Thu, 5 Oct 2017 14:47:01 +0200 [thread overview]
Message-ID: <19c477ab-a3dc-a994-905b-7a8d01298a76@redhat.com> (raw)
In-Reply-To: <20171005105157.10831-4-dgilbert@redhat.com>
On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote:
> From: Markus Armbruster <armbru@redhat.com>
>
> Screwed up in commit da76ee7.
Let me introduce you to these two aliases:
whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short"
pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short"
$ git whatis da76ee7
da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 2015-09-16)
pwhatis is more appropriate if you are including the commit at the end
of a parenthetical remark, like
... (see commit message for 53ec73e, "block: Use bdrv_drain to
replace uncessary bdrv_drain_all", 2015-07-07).
Paolo
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Message-Id: <20171002134538.23332-2-armbru@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
next prev parent reply other threads:[~2017-10-05 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 10:51 [Qemu-devel] [PULL 0/5] hmp queue Dr. David Alan Gilbert (git)
2017-10-05 10:51 ` [Qemu-devel] [PULL 1/5] hmp: Missing handle_errors Dr. David Alan Gilbert (git)
2017-10-05 10:51 ` [Qemu-devel] [PULL 2/5] hmp: Fix unknown command for subtable Dr. David Alan Gilbert (git)
2017-10-05 10:51 ` [Qemu-devel] [PULL 3/5] hmp-commands-info: Fix "info rocker-FOO" misspellings Dr. David Alan Gilbert (git)
2017-10-05 12:47 ` Paolo Bonzini [this message]
2017-10-05 14:21 ` Dr. David Alan Gilbert
2017-10-06 5:46 ` Markus Armbruster
2017-10-05 10:51 ` [Qemu-devel] [PULL 4/5] hmp-commands-info: Move Texinfo stanzas to conventional place Dr. David Alan Gilbert (git)
2017-10-05 10:51 ` [Qemu-devel] [PULL 5/5] hmp-commands-info: Change "@findex FOO" to "@findex info FOO" Dr. David Alan Gilbert (git)
2017-10-05 15:53 ` [Qemu-devel] [PULL 0/5] hmp queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c477ab-a3dc-a994-905b-7a8d01298a76@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).