From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 302D1C433DB for ; Tue, 26 Jan 2021 09:09:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8234E230FC for ; Tue, 26 Jan 2021 09:09:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8234E230FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4KLf-0002ya-Dk for qemu-devel@archiver.kernel.org; Tue, 26 Jan 2021 04:09:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4KKp-0002Iz-St for qemu-devel@nongnu.org; Tue, 26 Jan 2021 04:08:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l4KKn-0005ma-81 for qemu-devel@nongnu.org; Tue, 26 Jan 2021 04:08:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611652103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lVebEM+TYK+hwn0m9C69wkro+H1qDTDxP982Lwre7js=; b=cVkzLf0ilwpG/giIHVtzHnvj8d3J0k/shy5RoNSHcXI6xN+kMRwPSF+m+qDo+x7cRfELbb Nu78cZKZ8MlR0plRR5QPgX5ZmLATPe7H9kNkaONe4UWHCCAv5IAgncx2emAYUC8tRycq9C oOVW7J3jg6QaPXfdl+bEK29EYFVWvic= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-SD0bsrxDOXmYHnFmhGCSwg-1; Tue, 26 Jan 2021 04:08:21 -0500 X-MC-Unique: SD0bsrxDOXmYHnFmhGCSwg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 485C684A5E1 for ; Tue, 26 Jan 2021 09:08:20 +0000 (UTC) Received: from thuth.remote.csb (ovpn-115-18.ams2.redhat.com [10.36.115.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id E97ED6267C; Tue, 26 Jan 2021 09:08:15 +0000 (UTC) Subject: Re: [PATCH] gitlab-ci.yml: Avoid recompiling the sources in the test jobs To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210126065757.403853-1-thuth@redhat.com> From: Thomas Huth Message-ID: <19cbfd81-3d33-dbc1-b8f4-fecdce8ce09c@redhat.com> Date: Tue, 26 Jan 2021 10:08:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 26/01/2021 08.36, Philippe Mathieu-Daudé wrote: > On 1/26/21 7:57 AM, Thomas Huth wrote: >> Currently, our check-system-* jobs are recompiling the whole sources >> again. This happens due to the fact that the jobs are checking out >> the whole source tree and required submodules again, and only try >> to use the "build" directory with the binaries and object files as an >> artifact from the previous stage - which simply does not work right >> anymore (with the current version of meson). Due to some changed >> time stamps, meson/ninja are always trying to rebuild the whole tree. >> >> In the long run, we could likely use "meson test --no-rebuild", but >> there is still some work going on in that area to improve the user >> experience. So until this has been done, simply avoid recompiling the >> sources with a trick: pass NINJA=":" to the make process in the test >> jobs. Also check out the submodules manually before updating the >> timestamps in the build folder, so that the binaries are definitely >> newer that all the source files. >> This saves ca. 10 - 15 minutes of precious CI cycles in each run. >> >> Suggested-by: Paolo Bonzini >> Signed-off-by: Thomas Huth >> --- >> .gitlab-ci.yml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> index de3a3d25b5..16fea25ba9 100644 >> --- a/.gitlab-ci.yml >> +++ b/.gitlab-ci.yml >> @@ -38,9 +38,11 @@ include: >> stage: test >> image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest >> script: >> + - scripts/git-submodule.sh update >> + $(grep GIT_SUBMODULES build/config-host.mak | sed 's/GIT_SUBMODULES=//') >> - cd build >> - find . -type f -exec touch {} + >> - - make $MAKE_CHECK_ARGS >> + - make NINJA=":" $MAKE_CHECK_ARGS > > This ninja trick deserves a comment in the YAML file. I'll add: # Avoid recompiling by hiding ninja with NINJA=":" Ok? Thomas