qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Frajo <franz.haider@jolla.com>, Riku Voipio <riku.voipio@iki.fi>
Cc: qemu-devel@nongnu.org
Subject: Re: linux-user: Support f_flags in statfs64 when available.
Date: Thu, 30 Jan 2020 17:52:20 +0100	[thread overview]
Message-ID: <19d426e3-bc5f-7d47-3674-33384b08ab40@vivier.eu> (raw)
In-Reply-To: <2e405fe7-efab-dae5-93d6-02575773fd6e@jolla.com>

Le 30/01/2020 à 14:00, Frajo a écrit :
> linux-user: Support f_flags in statfs64 when available.
> Same as d4247ec2d79ef2477cb886fa688706b068119736 but for statfs64
> When running rpm within qemu-arm-dynamic this could cause rpm fail with
> an error like
> "installing package A needs B MB on the C filesystem" depending on what
> is in memory in f_flags.
> https://github.com/rpm-software-management/rpm/blob/af06db1d5558870f7fb8f5c502572c2d27af5c71/lib/transaction.c#L164
> 
> 
> From 6ceb5662b5fae827d2c0cdd9896eec75997c060a Mon Sep 17 00:00:00 2001
> From: Franz-Josef Haider <franz.haider@jolla.com>
> Date: Thu, 30 Jan 2020 14:28:24 +0200
> Subject: [PATCH 1/1] linux-user: Support f_flags in statfs64 when
> available.
> 
> Same as d4247ec2d79ef2477cb886fa688706b068119736 but for statfs64
> 
> Signed-off-by: Franz-Josef Haider <franz.haider@jolla.com>
> ---
>  linux-user/syscall.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index d60142f069..45782b1009 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -8997,6 +8997,11 @@ static abi_long do_syscall1(void *cpu_env, int
> num, abi_long arg1,
>              __put_user(stfs.f_fsid.__val[1], &target_stfs->f_fsid.val[1]);
>              __put_user(stfs.f_namelen, &target_stfs->f_namelen);
>              __put_user(stfs.f_frsize, &target_stfs->f_frsize);
> +#ifdef _STATFS_F_FLAGS
> +            __put_user(stfs.f_flags, &target_stfs->f_flags);
> +#else
> +            __put_user(0, &target_stfs->f_flags);
> +#endif
>              memset(target_stfs->f_spare, 0, sizeof(target_stfs->f_spare));
>              unlock_user_struct(target_stfs, arg3, 1);
>          }

Reviewed-by: Laurent Vivier <laurent@vivier.eu>


  reply	other threads:[~2020-01-30 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 13:00 linux-user: Support f_flags in statfs64 when available Frajo
2020-01-30 16:52 ` Laurent Vivier [this message]
2020-10-23 11:29   ` Franz-Josef Haider
2020-10-23 12:28     ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19d426e3-bc5f-7d47-3674-33384b08ab40@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=franz.haider@jolla.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).