Re: [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

[Thomas Huth <thuth@redhat.com>]

On 27/05/2024 13.26, Nicholas Piggin wrote:
> On Mon May 27, 2024 at 5:32 PM AEST, Thomas Huth wrote:
>> On 25/05/2024 05.13, Nicholas Piggin wrote:
>>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>>> ---
>>>    tests/qtest/migration-test.c | 4 +++-
>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
>>> index b7e3406471..c13535c37d 100644
>>> --- a/tests/qtest/migration-test.c
>>> +++ b/tests/qtest/migration-test.c
>>> @@ -21,6 +21,7 @@
>>>    #include "chardev/char.h"
>>>    #include "crypto/tlscredspsk.h"
>>>    #include "qapi/qmp/qlist.h"
>>> +#include "libqos/libqos-spapr.h"
>>
>> It's a little bit unfortunate to include a libqos header in a non-qos test
>> ... so in case you respin, maybe add a comment at the end of the line like:
>>
>>     /* just for PSERIES_DEFAULT_CAPABILITIES */
>>
>> ?
> 
> Same as other uses of it by the looks. Could just put it in a new
> header in tests/qtest/ppc-util.h or something?

Yes, that would be cleaner, indeed.

  Thanks,
   Thomas