From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3WT8-0005Hq-V1 for qemu-devel@nongnu.org; Tue, 03 Jun 2008 09:22:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3WT6-0005HW-Ua for qemu-devel@nongnu.org; Tue, 03 Jun 2008 09:22:30 -0400 Received: from [199.232.76.173] (port=44947 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3WT6-0005HT-P5 for qemu-devel@nongnu.org; Tue, 03 Jun 2008 09:22:28 -0400 Received: from rv-out-0708.google.com ([209.85.198.245]:61040) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3WT7-0008Tu-1s for qemu-devel@nongnu.org; Tue, 03 Jun 2008 09:22:29 -0400 Received: by rv-out-0708.google.com with SMTP id f25so1211507rvb.22 for ; Tue, 03 Jun 2008 06:22:25 -0700 (PDT) Message-ID: <19f34abd0806030622id2879e5u86bd55e581e088eb@mail.gmail.com> Date: Tue, 3 Jun 2008 15:22:25 +0200 From: "Vegard Nossum" Subject: Re: [Qemu-devel] [PATCH] Remove dead-code (else-block) from block-qcow.c In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc Bevand Cc: qemu-devel@nongnu.org On Tue, Jun 3, 2008 at 7:49 AM, Marc Bevand wrote: > X-BeenThere: qemu-devel@nongnu.org > X-Mailman-Version: 2.1.5 > Precedence: list > Reply-To: qemu-devel@nongnu.org > List-Id: qemu-devel.nongnu.org > List-Unsubscribe: , > > List-Archive: > List-Post: > List-Help: > List-Subscribe: , > > Sender: qemu-devel-bounces+vegard.nossum=gmail.com@nongnu.org > Errors-To: qemu-devel-bounces+vegard.nossum=gmail.com@nongnu.org > > "if (allocate == 1)" is always true because the value of "allocate" is > checked a few lines above. > > Patch made against SVN's rev 4622. > > Signed-off-by: Marc Bevand gmail.com> > > Please see: > http://etud.epita.fr/~bevand_m/pub/qemu-qcow-remove-dead-code.patch Uhm, what funny thing is this and why is my name in there? O.o (Did mailman mess up?) Vegard -- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036