Re: [Qemu-devel] [PATCH v2 2/3] qapi: Add reason to SHUTDOWN and RESET events

[Dominik Csapak <d.csapak@proxmox.com>]

On 12/3/18 10:36 PM, Eric Blake wrote:
> On 12/3/18 3:26 AM, Dominik Csapak wrote:
>> This makes it possible to determine what the exact reason was for
>> a RESET or a SHUTDOWN. A management layer might need the specific reason
>> of those events to determine which cleanups or other actions it needs 
>> to do.
>>
>> This patch also fixes the iotests to include the reason in the output.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   qapi/run-state.json        |  8 ++++++--
> 
>> +++ b/qapi/run-state.json
>> @@ -141,6 +141,8 @@
>>   # a guest-initiated ACPI shutdown request or other hardware-specific 
>> action)
>>   # rather than a host request (such as sending qemu a SIGINT). (since 
>> 2.10)
>>   #
>> +# @reason: The @ShutdownCause which resulted in the SHUTDOWN.
> 
> Missing a '(since 4.0)' clause.
> 

yeah, i guessed so, but was not sure which version to write.
will do in an upcoming v3

> 
>> @@ -180,6 +182,8 @@
>>   # rather than a host request (such as the QMP command system_reset).
>>   # (since 2.10)
>>   #
>> +# @reason: The @ShutdownCause of the RESET.
> 
> and again.
>