From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V2R7z-0002q4-Ee
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 15:23:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V2R7x-0003aG-QO
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 15:23:07 -0400
Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:60623)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V2Qfc-0000hP-H0
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 14:53:48 -0400
Date: Thu, 25 Jul 2013 19:53:33 +0100
From: Alex Bligh <alex@alex.org.uk>
Message-ID: <1A5D30F9703985AD026648F0@nimrod.local>
In-Reply-To: <51F11AFB.9040008@siemens.com>
References: <1374396185-10870-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<20130725120530.GJ21033@stefanha-thinkpad.redhat.com>
	<C471CD9FB0C93A3C362BD247@nimrod.local> <51F11AFB.9040008@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff
Reply-To: Alex Bligh <alex@alex.org.uk>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Alex Bligh <alex@alex.org.uk>, Stefan Hajnoczi <stefanha@gmail.com>, Liu Ping Fan <qemulist@gmail.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>



--On 25 July 2013 14:32:59 +0200 Jan Kiszka <jan.kiszka@siemens.com> wrote:

>> I would happily at a QEMUClock of each type to AioContext. They are after
>> all pretty lightweight.
>
> What's the point of adding tones of QEMUClock instances? Considering
> proper abstraction, how are they different for each AioContext? Will
> they run against different clock sources, start/stop at different times?
> If the answer is "they have different timer list", then fix this
> incorrect abstraction.

Even if I fix the abstraction, there is a question of whether it is
necessary to have more than one timer list per AioContext, because
the timer list is fundamentally per clock-source. I am currently
just using QEMU_CLOCK_REALTIME as that's what the block drivers normally
want. Will block drivers ever want timers from a different clock source?

-- 
Alex Bligh