From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21FC5C3DA6D for ; Tue, 20 May 2025 20:39:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uHTjg-0003WH-TE; Tue, 20 May 2025 16:38:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHTje-0003Vk-1W for qemu-devel@nongnu.org; Tue, 20 May 2025 16:38:50 -0400 Received: from out-173.mta1.migadu.com ([2001:41d0:203:375::ad]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHTjb-0006PL-GX for qemu-devel@nongnu.org; Tue, 20 May 2025 16:38:49 -0400 Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747773521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LlC0TODa7KxYUpfpU68321KNCp6H6FT3J7MnALnUViM=; b=Q99WFAhUM4c9CvOUBZ9CEYtfHJgTzvdjDRM8TVre/iZalux4nGAiMJQXSEMr6/NeJLtSYy VNgLjCb7/Xp9aFDFLoaaAQRAosNW22/ChM2umYCctjTh8RPhMsHNYcgUJu9jQ1BThTu3Rn 5qvYmN7YE9Jgq1Pv4LkGF3zvpmJOO4o= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: [PATCH v13 5/5] qtest/cxl: Add aarch64 virt test for CXL X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Itaru Kitayama In-Reply-To: <20250519135413.000026b4@huawei.com> Date: Wed, 21 May 2025 05:38:21 +0900 Cc: qemu-devel@nongnu.org, Fan Ni , Peter Maydell , mst@redhat.com, linux-cxl@vger.kernel.org, linuxarm@huawei.com, qemu-arm@nongnu.org, Yuquan Wang , =?utf-8?Q?Philippe_Mathieu-Daud=C3=A9?= Content-Transfer-Encoding: quoted-printable Message-Id: <1BAB6FA9-F65A-41F4-ADC7-BE3F23E71AA0@linux.dev> References: <20250513111455.128266-1-Jonathan.Cameron@huawei.com> <20250513111455.128266-6-Jonathan.Cameron@huawei.com> <20250519135413.000026b4@huawei.com> To: Jonathan Cameron X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::ad; envelope-from=itaru.kitayama@linux.dev; helo=out-173.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Jonathan, > On May 19, 2025, at 21:54, Jonathan Cameron = wrote: >=20 > On Thu, 15 May 2025 18:04:18 +0900 > Itaru Kitayama wrote: >=20 >>> On May 13, 2025, at 20:14, Jonathan Cameron = wrote: >>>=20 >>> Add a single complex case for aarch64 virt machine. >>> Given existing much more comprehensive tests for x86 cover the >>> common functionality, a single test should be enough to verify >>> that the aarch64 part continue to work. >>>=20 >>> Signed-off-by: Jonathan Cameron >>> --- >>> tests/qtest/cxl-test.c | 59 = ++++++++++++++++++++++++++++++++--------- >>> tests/qtest/meson.build | 1 + >>> 2 files changed, 47 insertions(+), 13 deletions(-) >>>=20 >>> diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c >>> index a600331843..c7189d6222 100644 >>> --- a/tests/qtest/cxl-test.c >>> +++ b/tests/qtest/cxl-test.c >>> @@ -19,6 +19,12 @@ >>> "-device pxb-cxl,id=3Dcxl.1,bus=3Dpcie.0,bus_nr=3D53 " \ >>> "-M = cxl-fmw.0.targets.0=3Dcxl.0,cxl-fmw.0.targets.1=3Dcxl.1,cxl-fmw.0.size=3D4= G " >>>=20 >>> +#define QEMU_VIRT_2PXB_CMD \ >>> + "-machine virt,cxl=3Don -cpu max " \ >>> + "-device pxb-cxl,id=3Dcxl.0,bus=3Dpcie.0,bus_nr=3D52 " \ >>> + "-device pxb-cxl,id=3Dcxl.1,bus=3Dpcie.0,bus_nr=3D53 " \ >>> + "-M = cxl-fmw.0.targets.0=3Dcxl.0,cxl-fmw.0.targets.1=3Dcxl.1,cxl-fmw.0.size=3D4= G " >>> + >>> #define QEMU_RP \ >>> "-device cxl-rp,id=3Drp0,bus=3Dcxl.0,chassis=3D0,slot=3D0 " >>>=20 >>> @@ -197,25 +203,52 @@ static void cxl_2pxb_4rp_4t3d(void) >>> qtest_end(); >>> rmdir(tmpfs); >>> } >>> + >>> +static void cxl_virt_2pxb_4rp_4t3d(void) >>> +{ >>> + g_autoptr(GString) cmdline =3D g_string_new(NULL); >>> + char template[] =3D "/tmp/cxl-test-XXXXXX"; >>> + const char *tmpfs; >>> + >>> + tmpfs =3D mkdtemp(template); >>> + >>> + g_string_printf(cmdline, QEMU_VIRT_2PXB_CMD QEMU_4RP QEMU_4T3D, >>> + tmpfs, tmpfs, tmpfs, tmpfs, tmpfs, tmpfs, >>> + tmpfs, tmpfs); >>> + >>> + qtest_start(cmdline->str); >>> + qtest_end(); >>> + rmdir(tmpfs); >>> +} >>> #endif /* CONFIG_POSIX */ >>>=20 >>> int main(int argc, char **argv) >>> { >>> - g_test_init(&argc, &argv, NULL); >>> + const char *arch =3D qtest_get_arch(); >>>=20 >>> - qtest_add_func("/pci/cxl/basic_hostbridge", cxl_basic_hb); >>> - qtest_add_func("/pci/cxl/basic_pxb", cxl_basic_pxb); >>> - qtest_add_func("/pci/cxl/pxb_with_window", = cxl_pxb_with_window); >>> - qtest_add_func("/pci/cxl/pxb_x2_with_window", = cxl_2pxb_with_window); >>> - qtest_add_func("/pci/cxl/rp", cxl_root_port); >>> - qtest_add_func("/pci/cxl/rp_x2", cxl_2root_port); >>> + g_test_init(&argc, &argv, NULL); >>> + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D= 0) { >>> + qtest_add_func("/pci/cxl/basic_hostbridge", cxl_basic_hb); >>> + qtest_add_func("/pci/cxl/basic_pxb", cxl_basic_pxb); >>> + qtest_add_func("/pci/cxl/pxb_with_window", = cxl_pxb_with_window); >>> + qtest_add_func("/pci/cxl/pxb_x2_with_window", = cxl_2pxb_with_window); >>> + qtest_add_func("/pci/cxl/rp", cxl_root_port); >>> + qtest_add_func("/pci/cxl/rp_x2", cxl_2root_port); >>> #ifdef CONFIG_POSIX >>> - qtest_add_func("/pci/cxl/type3_device", cxl_t3d_deprecated); >>> - qtest_add_func("/pci/cxl/type3_device_pmem", = cxl_t3d_persistent); >>> - qtest_add_func("/pci/cxl/type3_device_vmem", cxl_t3d_volatile); >>> - qtest_add_func("/pci/cxl/type3_device_vmem_lsa", = cxl_t3d_volatile_lsa); >>> - qtest_add_func("/pci/cxl/rp_x2_type3_x2", cxl_1pxb_2rp_2t3d); >>> - qtest_add_func("/pci/cxl/pxb_x2_root_port_x4_type3_x4", = cxl_2pxb_4rp_4t3d); >>> + qtest_add_func("/pci/cxl/type3_device", = cxl_t3d_deprecated); >>> + qtest_add_func("/pci/cxl/type3_device_pmem", = cxl_t3d_persistent); >>> + qtest_add_func("/pci/cxl/type3_device_vmem", = cxl_t3d_volatile); >>> + qtest_add_func("/pci/cxl/type3_device_vmem_lsa", = cxl_t3d_volatile_lsa); >>> + qtest_add_func("/pci/cxl/rp_x2_type3_x2", = cxl_1pxb_2rp_2t3d); >>> + qtest_add_func("/pci/cxl/pxb_x2_root_port_x4_type3_x4", >>> + cxl_2pxb_4rp_4t3d); >>> #endif >>> + } else if (strcmp(arch, "aarch64") =3D=3D 0) { >>> +#ifdef CONFIG_POSIX >>> + = qtest_add_func("/pci/cxl/virt/pxb_x2_root_port_x4_type3_x4", >>> + cxl_virt_2pxb_4rp_4t3d); >>> +#endif >>> + } >>> + >>> return g_test_run(); >>> } >>> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build >>> index 7daf619845..361000267a 100644 >>> --- a/tests/qtest/meson.build >>> +++ b/tests/qtest/meson.build >>> @@ -258,6 +258,7 @@ qtests_aarch64 =3D \ >>> (config_all_accel.has_key('CONFIG_TCG') and = \ >>> config_all_devices.has_key('CONFIG_TPM_TIS_I2C') ? = ['tpm-tis-i2c-test'] : []) + \ >>> (config_all_devices.has_key('CONFIG_ASPEED_SOC') ? qtests_aspeed64 = : []) + \ >>> + qtests_cxl + = \ >>> ['arm-cpu-features', >>> 'numa-test', >>> 'boot-serial-test', >>> --=20 >>> 2.43.0 >>>=20 >>=20 >> ~/projects/qemu/build$ meson test qtest-aarch64/cxl-test >> ninja: Entering directory `/home/realm/projects/qemu/build' >> [1/8] Generating qemu-version.h with a custom command (wrapped by = meson to capture output) >> 1/1 qemu:qtest+qtest-aarch64 / qtest-aarch64/cxl-test OK = 0.17s 1 subtests passed >>=20 >> Ok: 1 >> Expected Fail: 0 >> Fail: 0 >> Unexpected Pass: 0 >> Skipped: 0 >> Timeout: 0 >>=20 >> Tested-by: Itaru Kitayama > >>=20 >> Jonathan, would you push your branch this series applied? I manually = applied your series no issues though. >=20 > I'm reluctant to push a 'normal' staging CXL tree whilst we have the = TCG > issue outstanding (which is in mainline). > I can probably push one with a name that makes it clear we know it = will > crash under some circumstances though. I'll aim to get that done later = this week. Okay, and understood. >=20 > After talking to Richard Henderson I'm going to spin some images etc = to > make it easier for him to replicate that TCG issue. >=20 > Thanks for reviews. The comments are from Zhijian. Itaru. >=20 > Jonathan >=20 >>=20 >>=20 >=20