From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] hw/arm/mps2: Fix ID register errors on AN511 and AN385
Date: Thu, 23 Aug 2018 21:20:25 -0700 [thread overview]
Message-ID: <1a00a128-08ca-a214-5f69-971a867cdde7@linaro.org> (raw)
In-Reply-To: <20180823175225.22612-1-peter.maydell@linaro.org>
On 08/23/2018 10:52 AM, Peter Maydell wrote:
> Fix MPS2 SCC config register values for the mps2-an511
> and mps2-an385 boards:
> * the SCC_AID bits [23:20] specify the FPGA build target board revision,
> and the SCC_CFG4 register specifies the actual board revision, so
> these should have matching values. Claim to be board revision C,
> consistently -- we had the revision in the wrong part of SCC_AID.
> * SCC_ID bits [15:4] should be the board number in hex, not decimal
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This fixes a bug that I noticed for the AN505 model and fixed there,
> but forgot to also fix on our other MPS image models.
>
> hw/arm/mps2.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2018-08-24 4:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 17:52 [Qemu-devel] [PATCH] hw/arm/mps2: Fix ID register errors on AN511 and AN385 Peter Maydell
2018-08-24 4:20 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a00a128-08ca-a214-5f69-971a867cdde7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).