From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9AACA9EA0 for ; Tue, 22 Oct 2019 12:53:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14AC72075A for ; Tue, 22 Oct 2019 12:53:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14AC72075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMtfU-0003F8-89 for qemu-devel@archiver.kernel.org; Tue, 22 Oct 2019 08:53:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMteL-0002fo-Bw for qemu-devel@nongnu.org; Tue, 22 Oct 2019 08:52:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMteJ-0003fj-8y for qemu-devel@nongnu.org; Tue, 22 Oct 2019 08:52:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57122) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMteJ-0003fN-0u for qemu-devel@nongnu.org; Tue, 22 Oct 2019 08:52:31 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C1FB360A8C for ; Tue, 22 Oct 2019 12:52:29 +0000 (UTC) Received: by mail-wm1-f71.google.com with SMTP id u17so1875990wmd.3 for ; Tue, 22 Oct 2019 05:52:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gmvf0BVZShPGJSnkCjp4EkXvRxogE/PLOWq6DjpJu2c=; b=f8FAXhiMRdV6b9Pp7xaTHb3wR+0Dj48ZaB37g14yX9g9YK/y6PJHS7UBTSZIrRNKFa aq13B6JufaT0GAXTKpJBTvk20+BbB9t1xbZGvA9Y8T/3PZt7vWERtTIekzjRBrLJ8gv3 4NnYJGXm+Im2VMc3Yl7a9u1r7S80rrdlQINfTuToDsv7liwvKJywHHpXTLJxcrVHRPQr jKtU9Iack1AlOUOXN08WXf3H3vAIwsWi6d7MVpP18CakpkhTkbJZs33QvgGYBLahyIrL ig6tcqF1HKWogmY+Mw3hXKhcrjwQSfb8MqTO3s9Hn9BRcHLwF+7qw2uuI1siSs7692BT qKeA== X-Gm-Message-State: APjAAAVt0cSL77Y8kEV9mn4RWD3QKfwvDKk2uDucbeNTiOt4pnXgf1CY goDgBlZhuysYX2vC5N4DxeuMUIVX8qAkEhPMSFpSbtG3NccLO+wY0ZUE2KLOZJyAqadZsvY2aOh wtE5wrNnNCf6x24c= X-Received: by 2002:a5d:6281:: with SMTP id k1mr3472064wru.69.1571748748471; Tue, 22 Oct 2019 05:52:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJQp8T5eHdBaFhOuIzdgZBTL1G/LdslrkQCEPQ+k9R00VBDwSIcjj6H4egtGRrGyrz7fPnJA== X-Received: by 2002:a5d:6281:: with SMTP id k1mr3472025wru.69.1571748747953; Tue, 22 Oct 2019 05:52:27 -0700 (PDT) Received: from [192.168.1.41] (129.red-83-57-174.dynamicip.rima-tde.net. [83.57.174.129]) by smtp.gmail.com with ESMTPSA id z13sm21247346wrm.64.2019.10.22.05.52.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2019 05:52:27 -0700 (PDT) Subject: Re: [PATCH] qemu-options.hx: Update for reboot-timeout parameter To: Markus Armbruster , Han Han References: <20191015151451.727323-1-hhan@redhat.com> <87d0epqp5r.fsf@dusky.pond.sub.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <1a07f8dd-88e8-c8f0-f76e-2fe62259cac3@redhat.com> Date: Tue, 22 Oct 2019 14:52:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <87d0epqp5r.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/22/19 8:18 AM, Markus Armbruster wrote: > Han Han writes: >=20 >> Since ee5d0f89d, -1 is not valid for the value of reboot-timeout. Upda= te >> that in qemu-options doc. >> >> Signed-off-by: Han Han >> --- >> qemu-options.hx | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/qemu-options.hx b/qemu-options.hx >> index 793d70ff..6b92a916 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -327,8 +327,8 @@ format(true color). The resolution should be suppo= rted by the SVGA mode, so > A splash picture could be passed to bios, enabling user to show it = as logo, > when option splash=3D@var{sp_name} is given and menu=3Don, If firmw= are/BIOS > supports them. Currently Seabios for X86 system support it. > limitation: The splash file could be a jpeg file or a BMP file in 2= 4 BPP > format(true color). The resolution should be supported by the SVGA = mode, so >> the recommended is 320x240, 640x480, 800x640. >> =20 >> A timeout could be passed to bios, guest will pause for @var{rb_time= out} ms >> -when boot failed, then reboot. If @var{rb_timeout} is '-1', guest wil= l not >> -reboot, qemu passes '-1' to bios by default. Currently Seabios for X8= 6 >> +when boot failed, then reboot. If @option{reboot-timeout} is not set, >> +guest will not reboot by default. Currently Seabios for X86 >> system support it. >> =20 >> Do strict boot via @option{strict=3Don} as far as firmware/BIOS >=20 > Preexisting: "could be passed" sounds awkward. Same in the previous > paragraph. Not this patch's problem, so: >=20 > Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 I assume this patch will go via qemu-trivial.