From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A995CC433E0 for ; Fri, 3 Jul 2020 05:34:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74619206E2 for ; Fri, 3 Jul 2020 05:34:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GqdY2wf9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74619206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrELd-0001Mc-Pn for qemu-devel@archiver.kernel.org; Fri, 03 Jul 2020 01:34:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrEL4-0000p7-Lo for qemu-devel@nongnu.org; Fri, 03 Jul 2020 01:34:18 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:57894 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jrEL2-0006TB-Ru for qemu-devel@nongnu.org; Fri, 03 Jul 2020 01:34:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593754455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbYMKsvzLQ5XquOqWTtyZREyyg1cXbg4U4M5thGXZ3E=; b=GqdY2wf9GrtE4EI4tUxFM7f2eXYWzPbM8qyhmSqEkgXoy55JMONcOiOQcNVBSrG5CP1tWd gCfx4i/fm++XBg9vSbtR5P59jrUR44pUGzIcWcvDtb0Qe80VdSp8eXRXlJja6KeAuOWQrh +jZ2suCNx7B7tlSgh0vOUwP1Htsuhks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-Q8TuZL3jP-6XAzVUP4x4AA-1; Fri, 03 Jul 2020 01:34:13 -0400 X-MC-Unique: Q8TuZL3jP-6XAzVUP4x4AA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6559E7BB3; Fri, 3 Jul 2020 05:34:12 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-87.ams2.redhat.com [10.36.112.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 428D25BAE4; Fri, 3 Jul 2020 05:34:11 +0000 (UTC) Subject: Re: [PATCH] softmmu/vl: Remove the check for colons in -accel parameters From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini References: <20200618074001.13642-1-thuth@redhat.com> Message-ID: <1a135eb1-8ea6-80f2-85d7-40c8da92c1d1@redhat.com> Date: Fri, 3 Jul 2020 07:34:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200618074001.13642-1-thuth@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/03 01:34:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 18/06/2020 09.40, Thomas Huth wrote: > The new -accel option does not accept colons in the parameters anymore > (since it does not convert the parameters to -machine accel=... parameters > anymore). Thus we can now remove the check for colons in -accel: > > $ qemu-system-x86_64 -accel kvm:tcg > qemu-system-x86_64: -accel kvm:tcg: invalid accelerator kvm:tcg > > Signed-off-by: Thomas Huth > --- > softmmu/vl.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index f669c06ede..273acfcf6b 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -3485,11 +3485,6 @@ void qemu_init(int argc, char **argv, char **envp) > g_slist_free(accel_list); > exit(0); > } > - if (optarg && strchr(optarg, ':')) { > - error_report("Don't use ':' with -accel, " > - "use -M accel=... for now instead"); > - exit(1); > - } > break; > case QEMU_OPTION_usb: > olist = qemu_find_opts("machine"); > Ping? Thomas