qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 2/2] tests: fix echi/ehci typo
Date: Thu, 26 Sep 2019 13:24:18 +0200	[thread overview]
Message-ID: <1a20ceca-804e-4592-c499-57f5cd973e65@redhat.com> (raw)
In-Reply-To: <20190926111955.17276-3-marcandre.lureau@redhat.com>

On 26/09/2019 13:19, Marc-André Lureau wrote:
> While at it, simplify using $(land).
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/Makefile.include | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 0595914526..3543451ed3 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -182,9 +182,7 @@ check-qtest-i386-$(CONFIG_PVPANIC) += tests/pvpanic-test$(EXESUF)
>  check-qtest-i386-$(CONFIG_I82801B11) += tests/i82801b11-test$(EXESUF)
>  check-qtest-i386-$(CONFIG_IOH3420) += tests/ioh3420-test$(EXESUF)
>  check-qtest-i386-$(CONFIG_USB_UHCI) += tests/usb-hcd-uhci-test$(EXESUF)
> -ifeq ($(CONFIG_USB_ECHI)$(CONFIG_USB_UHCI),yy)
> -check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF)
> -endif
> +check-qtest-i386-$(call land,$(CONFIG_USB_EHCI),$(CONFIG_USB_UHCI)) += tests/usb-hcd-ehci-test$(EXESUF)
>  check-qtest-i386-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
>  check-qtest-i386-y += tests/cpu-plug-test$(EXESUF)
>  check-qtest-i386-y += tests/q35-test$(EXESUF)
> 

Reviewed-by: Laurent Vivier <lvivier@redhat.com>


  reply	other threads:[~2019-09-26 11:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 11:19 [PATCH 0/2] Fix ehci-test Marc-André Lureau
2019-09-26 11:19 ` [PATCH 1/2] tests: fix usb-hcd-ehci-test compilation Marc-André Lureau
2019-09-26 11:23   ` Laurent Vivier
2019-09-26 11:49   ` Thomas Huth
2019-09-26 11:19 ` [PATCH 2/2] tests: fix echi/ehci typo Marc-André Lureau
2019-09-26 11:24   ` Laurent Vivier [this message]
2019-09-26 11:39   ` Thomas Huth
2019-09-26 12:53     ` Philippe Mathieu-Daudé
2019-09-27  6:23 ` [PATCH 0/2] Fix ehci-test no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a20ceca-804e-4592-c499-57f5cd973e65@redhat.com \
    --to=lvivier@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).