qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: "David Hildenbrand" <david@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH] travis.yml: Test the s390-ccw build, too
Date: Fri, 7 Feb 2020 10:56:18 +0100	[thread overview]
Message-ID: <1a263ca4-68fd-2afc-ddf9-ed7231467b94@redhat.com> (raw)
In-Reply-To: <20200207104751.36609b11.cohuck@redhat.com>

On 07/02/2020 10.47, Cornelia Huck wrote:
> On Thu,  6 Feb 2020 21:25:43 +0100
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> Since we can now use a s390x host on Travis, we can also build and
>> test the s390-ccw bios images there. For this we have to make sure
>> that roms/SLOF is checked out, too, and then move the generated *.img
>> files to the right location before running the tests.
> 
> Oh, nice.
> 
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  .travis.yml | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 6c0ec6cf69..c0eeff9caa 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -508,6 +508,16 @@ matrix:
>>        env:
>>          - TEST_CMD="make check check-tcg V=1"
>>          - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},s390x-linux-user"
>> +      script:
>> +        - ( cd ${SRC_DIR} ; git submodule update --init roms/SLOF )
>> +        - BUILD_RC=0 && make -j${JOBS} || BUILD_RC=$?
>> +        - |
>> +          if [ "$BUILD_RC" -eq 0 ] ; then
>> +              mv pc-bios/s390-ccw/*.img pc-bios/ ;
>> +              ${TEST_CMD} ;
> 
> Out of curiousity: Which kind of tests are run for the net image?

The tests/qtest/pxe-test.c test exercises the netboot.
(and tests/qtest/cdrom-test.c execises booting from disk)

We could maybe add also add more complex test in "check-acceptance"
later, but that's something for another day...

 Thomas



  reply	other threads:[~2020-02-07  9:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 20:25 [PATCH] travis.yml: Test the s390-ccw build, too Thomas Huth
2020-02-06 22:40 ` Philippe Mathieu-Daudé
2020-02-07  9:47 ` Cornelia Huck
2020-02-07  9:56   ` Thomas Huth [this message]
2020-02-07 11:05     ` Christian Borntraeger
2020-02-07 11:13 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a263ca4-68fd-2afc-ddf9-ed7231467b94@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).