Re: [Qemu-devel] [PATCH 2/2] scripts/coverity-scan: Add Docker support

[Paolo Bonzini <pbonzini@redhat.com>]

On 13/11/2018 20:37, Philippe Mathieu-Daudé wrote:
> Calling "make docket-image-fedora" you can reduce this script to:
> 
> -- >8 --
> FROM qemu:fedora
> ENV PACKAGES \
>     $PACKAGES \
>     alsa-lib-devel \
>     curl \
>     cyrus-sasl-devel \
>     libepoxy-devel \
>     libgbm-devel \
>     libiscsi-devel \
>     libnfs-devel \
>     libseccomp-devel \
>     libudev-devel \
>     pulseaudio-libs-devel \
>     rdma-core-devel \
>     wget \
>     xfsprogs-devel

... these can actually be moved to
tests/docker/dockerfiles/fedora.docker, improving the coverage...
> 
> RUN dnf install -y $PACKAGES
> RUN rpm -q $PACKAGES | sort > /packages.txt

... and removing the need for these two.

> ENV COVERITY_TOOL_BASE=/coverity-tools
> COPY run-coverity-scan run-coverity-scan
> RUN --mount=type=secret,id=coverity.token,required ./run-coverity-scan
> --update-tools-only --tokenfile /run/secrets/coverity.token

If the tokenfile is not needed when updating the tools, you could also
move the Dockerfile to tests/docker/dockerfiles/fedora-coverity.docker
and just do "make docker-image-fedora-coverity"

> +    # TODO: how do you get 'docker build' to print the output of the
> +    # commands it is running to its stdout? This would be useful for debug.

With make docker-image-*, you can just pass V=1.

Paolo