From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] iotests: Fix CID for VMDK afl image
Date: Wed, 28 Feb 2018 18:50:24 +0100 [thread overview]
Message-ID: <1a2f11f4-2807-69de-fa4a-46541753b487@redhat.com> (raw)
In-Reply-To: <20180202052310.7870-1-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
On 2018-02-02 06:23, Fam Zheng wrote:
> This reverts commit 76bf133c4 which updated the reference output, and
> fixed the reference image, because the code path we want to exercise is
> actually the invalid image size.
>
> The descriptor block in the image, which includes the CID to verify, has been
> invalid since the reference image was added. Since commit 9877860e7bd we report
> this error earlier than the "file too large", so 059.out mismatches.
>
> The binary change is generated along the operations of:
>
> $ bunzip2 afl9.vmdk.bz2
> $ qemu-img create -f vmdk fix.vmdk 1G
> $ dd if=afl9.vmdk of=fix.vmdk bs=512 count=1 conv=notrunc
> $ mv fix.vmdk afl9.vmdk
> $ bzip2 afl9.vmdk
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
Could you rebase this on master (so only the _notrun portion remains)?
It appears that v2 has hit master already...
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2018-02-28 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 5:23 [Qemu-devel] [PATCH v3] iotests: Fix CID for VMDK afl image Fam Zheng
2018-02-02 13:22 ` Max Reitz
2018-02-28 17:50 ` Max Reitz [this message]
2018-03-01 1:14 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a2f11f4-2807-69de-fa4a-46541753b487@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).