From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F23C4338F for ; Tue, 10 Aug 2021 14:46:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6020D60F02 for ; Tue, 10 Aug 2021 14:46:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6020D60F02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDT1j-0000B6-0W for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 10:46:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDSzw-0007XB-Qx for qemu-devel@nongnu.org; Tue, 10 Aug 2021 10:44:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDSzu-0001zl-8e for qemu-devel@nongnu.org; Tue, 10 Aug 2021 10:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628606692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CzCHs8Xln/BYj5mi7NgIoG7rpE6Ta5xVv5MRq1fn4Q4=; b=Kwa7W5lzkdInutPCJFk2FDGjpUTYEvpsXMPovdufdv/j+HBZ6QFGPjJNqBMn4HO6XCS81a DaWwGasiacL/20pHwrva+4M9WXgkuaB59LlB06syiAH1bJrPHB6Ms9wzFfGjB12Clu8cqz M2SnjA8fV0wV/HVGWSS7o6UlbLQFLGA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-KjQt783zMTWmmX7vbo4JVw-1; Tue, 10 Aug 2021 10:44:51 -0400 X-MC-Unique: KjQt783zMTWmmX7vbo4JVw-1 Received: by mail-wm1-f72.google.com with SMTP id a18-20020a05600c2252b02902531dcdc68fso1133294wmm.6 for ; Tue, 10 Aug 2021 07:44:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CzCHs8Xln/BYj5mi7NgIoG7rpE6Ta5xVv5MRq1fn4Q4=; b=Xk/mlGMycp3iyea1jcIMgJUu6deC9lltuwxdt3ccaQm0ikAhGUNJRxjQMctMETHKzf gJT9mm7ySo+vG1vMIp9894Ck5fSln5xLdbgk6CzX/CJadydu1Cmb7XyGxOR37P2f4ce6 m0ode38QxfvTandWBWl/oi62fVjDGgJHwSXtpnyGuXBd1WfR7buqZyuuc5sL/vmJ46Rz XIcMY3XEgrw4idjPkeTHgn4fhIt4FJVPI4FjgIHkXwFshUGluPSLhT0/SIEo4Jg8PNcU rNqmrGJ34FQXLfh74UfYnRUuNVykBt8Amb4BEcgvWfOYAToPqjyaqLl0NSFBcpAu38PV 8YeQ== X-Gm-Message-State: AOAM5304bAEYNrgI7i2sMtqr1zmN/DtWMo79dpmAmATM0tS10B77On+e PSA42hUceFVbDvEYjiZhr0X5gQYZUbM9vG9J1+63yM3PcCmZLoieIu/Y+ShVhJ4RKrUqoWlCFmL QNM6dtyCh6Jpi1y8= X-Received: by 2002:adf:f64a:: with SMTP id x10mr2434414wrp.287.1628606690053; Tue, 10 Aug 2021 07:44:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwivfBZ7yk5/0BDOZr7w2uYxLlwPPKyEkpv2Ed/jUKQLJ8sgEG/YBPeYqemxyXV/oagDTusqg== X-Received: by 2002:adf:f64a:: with SMTP id x10mr2434402wrp.287.1628606689927; Tue, 10 Aug 2021 07:44:49 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e46:160:b272:8083:d5:bc7d]) by smtp.gmail.com with ESMTPSA id s14sm21068312wmc.25.2021.08.10.07.44.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 07:44:48 -0700 (PDT) Subject: Re: [PATCH v7 06/33] block-copy: move detecting fleecing scheme to block-copy To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20210804093813.20688-1-vsementsov@virtuozzo.com> <20210804093813.20688-7-vsementsov@virtuozzo.com> From: Hanna Reitz Message-ID: <1a30dd07-ffba-6e71-540a-c5dd1f856afd@redhat.com> Date: Tue, 10 Aug 2021 16:44:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210804093813.20688-7-vsementsov@virtuozzo.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.704, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berrange@redhat.com, ehabkost@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, crosa@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, eblake@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 04.08.21 11:37, Vladimir Sementsov-Ogievskiy wrote: > We want to simplify initialization interface of copy-before-write > filter as we are going to make it public. So, let's detect fleecing > scheme exactly in block-copy code, to not pass this information through > extra levels. > > Why not just set BDRV_REQ_SERIALISING unconditionally: because we are > going to implement new more efficient fleecing scheme which will not > rely on backing feature. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/copy-before-write.h | 2 +- > include/block/block-copy.h | 3 +-- > block/backup.c | 21 +-------------------- > block/block-copy.c | 24 +++++++++++++++++++++--- > block/copy-before-write.c | 4 ++-- > 5 files changed, 26 insertions(+), 28 deletions(-) Reviewed-by: Hanna Reitz