qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Rogers <BROGERS@suse.com>
To: "ehabkost@redhat.com" <ehabkost@redhat.com>,
	"paul.c.lai@intel.com" <paul.c.lai@intel.com>,
	"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "tao3.xu@intel.com" <tao3.xu@intel.com>,
	"luwei.kang@intel.com" <luwei.kang@intel.com>,
	"wei.w.wang@intel.com" <wei.w.wang@intel.com>
Subject: Re: [Qemu-devel] Fixing Snowridge CPU model name and features
Date: Mon, 29 Jul 2019 15:22:11 +0000	[thread overview]
Message-ID: <1a33ae335f396d49689425e0137213efd9f28a7c.camel@suse.com> (raw)
In-Reply-To: <20190716155808.25010-1-paul.c.lai@intel.com>

On Tue, 2019-07-16 at 08:58 -0700, Paul Lai wrote:
> Changing the name to Snowridge from SnowRidge-Server.
> There is no client model of Snowridge, so "-Server" is unnecessary.
> 
> Removing CPUID_EXT_VMX from Snowridge cpu feature list.
> 
> Signed-off-by: Paul Lai <paul.c.lai@intel.com>
> Tested-by: Tao3 Xu <tao3.xu@intel.com>
> ---
>  target/i386/cpu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 63d89276fe..7f56e887ae 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -2688,7 +2688,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>          .model_id = "Intel Xeon Processor (Icelake)",
>      },
>      {
> -        .name = "SnowRidge-Server",
> +        .name = "Snowridge",
>          .level = 27,
>          .vendor = CPUID_VENDOR_INTEL,
>          .family = 6,
> @@ -2706,7 +2706,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
>              CPUID_FXSR | CPUID_SSE | CPUID_SSE2,
>          .features[FEAT_1_ECX] =
>              CPUID_EXT_SSE3 | CPUID_EXT_PCLMULQDQ | CPUID_EXT_MONITOR
> |
> -            CPUID_EXT_VMX |
>              CPUID_EXT_SSSE3 |
>              CPUID_EXT_CX16 |
>              CPUID_EXT_SSE41 |

What is the status of this patch with respect to the v4.1.0 release?
It would seem to me that it was targeted for this release, to get the
name and features right before codified in a released version, but
Intel would know better.

Bruce

  reply	other threads:[~2019-07-29 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 15:58 [Qemu-devel] Fixing Snowridge CPU model name and features Paul Lai
2019-07-29 15:22 ` Bruce Rogers [this message]
2019-07-29 15:46   ` Peter Maydell
2019-07-29 16:04     ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a33ae335f396d49689425e0137213efd9f28a7c.camel@suse.com \
    --to=brogers@suse.com \
    --cc=ehabkost@redhat.com \
    --cc=luwei.kang@intel.com \
    --cc=paul.c.lai@intel.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tao3.xu@intel.com \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).