From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Cc: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] subprojects/berkeley-testfloat-3: Update to fix a problem with compiler warnings
Date: Wed, 16 Aug 2023 14:49:07 +0200 [thread overview]
Message-ID: <1a33ef6c-a3ff-ca92-5288-de66bc2818aa@linaro.org> (raw)
In-Reply-To: <20230816091522.1292029-1-thuth@redhat.com>
On 16/8/23 11:15, Thomas Huth wrote:
> Update the berkeley-testfloat-3 wrap to include a patch provided by
> Olaf Hering. This fixes a problem with "control reaches end of non-void
> function [-Werror=return-type]" compiler warning/errors that are now
> enabled by default in certain versions of GCC.
e7af9751d9 has:
--- a/source/genCases_f32.c
+++ b/source/genCases_f32.c
@@ -411,6 +411,7 @@ static float32_t f32Random( void )
case 6:
return f32RandomQInfP3();
case 7:
+ default:
return f32RandomQInfPInf();
}
Why the default is with 7 and not 3 or 5?
Shouldn't we abort() or mark with __builtin_unreachable()?
>
> Reported-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> subprojects/berkeley-testfloat-3.wrap | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
next prev parent reply other threads:[~2023-08-16 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 9:15 [PATCH] subprojects/berkeley-testfloat-3: Update to fix a problem with compiler warnings Thomas Huth
2023-08-16 12:49 ` Philippe Mathieu-Daudé [this message]
2023-08-17 9:06 ` Olaf Hering
2023-08-17 11:31 ` Thomas Huth
2023-08-16 15:57 ` Peter Maydell
2023-08-16 16:11 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a33ef6c-a3ff-ca92-5288-de66bc2818aa@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=olaf@aepfle.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).