From: Hanna Reitz <hreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, qinwang@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] iotests: Test blockdev-reopen with iothreads and throttling
Date: Thu, 3 Feb 2022 17:45:10 +0100 [thread overview]
Message-ID: <1a3fc51d-ac2c-9c97-cb8c-673183ed2291@redhat.com> (raw)
In-Reply-To: <20220203140534.36522-3-kwolf@redhat.com>
On 03.02.22 15:05, Kevin Wolf wrote:
> The 'throttle' block driver implements .bdrv_co_drain_end, so
> blockdev-reopen will have to wait for it to complete in the polling
> loop at the end of qmp_blockdev_reopen(). This makes AIO_WAIT_WHILE()
> release the AioContext lock, which causes a crash if the lock hasn't
> correctly been taken.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/245 | 36 +++++++++++++++++++++++++++++++++---
> tests/qemu-iotests/245.out | 4 ++--
> 2 files changed, 35 insertions(+), 5 deletions(-)
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
prev parent reply other threads:[~2022-02-03 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 14:05 [PATCH 0/2] block: Fix crash in blockdev-reopen with iothreads Kevin Wolf
2022-02-03 14:05 ` [PATCH 1/2] block: Lock AioContext for drain_end in blockdev-reopen Kevin Wolf
2022-02-03 16:37 ` Hanna Reitz
2022-02-03 14:05 ` [PATCH 2/2] iotests: Test blockdev-reopen with iothreads and throttling Kevin Wolf
2022-02-03 16:45 ` Hanna Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a3fc51d-ac2c-9c97-cb8c-673183ed2291@redhat.com \
--to=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qinwang@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).