From: David Hildenbrand <david@redhat.com>
To: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Marek Kedzierski <mkedzier@redhat.com>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Qemu Developers <qemu-devel@nongnu.org>,
Peter Xu <peterx@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Auger Eric <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
teawater <teawaterz@linux.alibaba.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v2 07/10] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require)
Date: Thu, 10 Dec 2020 16:00:12 +0100 [thread overview]
Message-ID: <1a69a01e-9be5-0a3f-0ac6-c1f1fb4b4561@redhat.com> (raw)
In-Reply-To: <CAM9Jb+gOvCqW2rcz++SG1VZV0PoaZqx-_fE5X54PFttD-+1X_w@mail.gmail.com>
>> bool ram_block_discard_is_disabled(void)
>> {
>> - return qatomic_read(&ram_block_discard_disabled) > 0;
>> + return qatomic_read(&ram_block_discard_disablers);
>> }
> return value won't be bool?
The compiler does type conversion.
!= 0 -> true
== 0 -> false
[...]
> Apart from query above, looks good.
> Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-12-10 15:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 16:39 [PATCH v2 00/10] virtio-mem: vfio support David Hildenbrand
2020-12-08 16:39 ` [PATCH v2 01/10] memory: Introduce RamDiscardMgr for RAM memory regions David Hildenbrand
2020-12-09 18:27 ` Pankaj Gupta
2020-12-08 16:39 ` [PATCH v2 02/10] virtio-mem: Factor out traversing unplugged ranges David Hildenbrand
2020-12-09 19:08 ` Pankaj Gupta
2020-12-08 16:39 ` [PATCH v2 03/10] virtio-mem: Implement RamDiscardMgr interface David Hildenbrand
2020-12-08 16:39 ` [PATCH v2 04/10] vfio: Query and store the maximum number of DMA mappings David Hildenbrand
2020-12-08 16:39 ` [PATCH v2 05/10] vfio: Support for RamDiscardMgr in the !vIOMMU case David Hildenbrand
2020-12-08 16:39 ` [PATCH v2 06/10] vfio: Support for RamDiscardMgr in the vIOMMU case David Hildenbrand
2020-12-08 16:39 ` [PATCH v2 07/10] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require) David Hildenbrand
2020-12-10 14:54 ` Pankaj Gupta
2020-12-10 15:00 ` David Hildenbrand [this message]
2020-12-10 15:20 ` Pankaj Gupta
2020-12-08 16:39 ` [PATCH v2 08/10] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types David Hildenbrand
2020-12-09 18:47 ` Pankaj Gupta
2020-12-09 19:00 ` David Hildenbrand
2020-12-09 19:03 ` Pankaj Gupta
2020-12-08 16:39 ` [PATCH v2 09/10] virtio-mem: Require only coordinated discards David Hildenbrand
2020-12-09 18:51 ` Pankaj Gupta
2020-12-08 16:39 ` [PATCH v2 10/10] vfio: Disable only uncoordinated discards David Hildenbrand
2020-12-10 14:47 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a69a01e-9be5-0a3f-0ac6-c1f1fb4b4561@redhat.com \
--to=david@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=mkedzier@redhat.com \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.weiyang@linux.alibaba.com \
--cc=teawaterz@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).