From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Inès Varhol" <ines.varhol@telecom-paris.fr>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair@alistair23.me>,
Samuel Tardieu <samuel.tardieu@telecom-paris.fr>,
Thomas Huth <thuth@redhat.com>,
Arnaud Minier <arnaud.minier@telecom-paris.fr>
Subject: Re: [PATCH v4 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase
Date: Fri, 23 Feb 2024 13:26:10 +0100 [thread overview]
Message-ID: <1a71aa6a-0fe0-4407-a2f3-3fb9bacaed8c@linaro.org> (raw)
In-Reply-To: <20240207132517.198348-4-ines.varhol@telecom-paris.fr>
On 7/2/24 14:23, Inès Varhol wrote:
> The testcase contains :
> - `test_idr_reset_value()` :
> Checks the reset values of MODER, OTYPER, PUPDR, ODR and IDR.
> - `test_gpio_output_mode()` :
> Checks that writing a bit in register ODR results in the corresponding
> pin rising or lowering, if this pin is configured in output mode.
> - `test_gpio_input_mode()` :
> Checks that a input pin set high or low externally results
> in the pin rising and lowering.
> - `test_pull_up_pull_down()` :
> Checks that a floating pin in pull-up/down mode is actually high/down.
> - `test_push_pull()` :
> Checks that a pin set externally is disconnected when configured in
> push-pull output mode, and can't be set externally while in this mode.
> - `test_open_drain()` :
> Checks that a pin set externally high is disconnected when configured
> in open-drain output mode, and can't be set high while in this mode.
> - `test_bsrr_brr()` :
> Checks that writing to BSRR and BRR has the desired result in ODR.
> - `test_clock_enable()` :
> Checks that GPIO clock is at the right frequency after enabling it.
>
> Acked-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Arnaud Minier <arnaud.minier@telecom-paris.fr>
> Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
> ---
> tests/qtest/stm32l4x5_gpio-test.c | 586 ++++++++++++++++++++++++++++++
> tests/qtest/meson.build | 3 +-
> 2 files changed, 588 insertions(+), 1 deletion(-)
> create mode 100644 tests/qtest/stm32l4x5_gpio-test.c
LGTM!
prev parent reply other threads:[~2024-02-23 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 13:23 [PATCH v4 0/3] Add device STM32L4x5 GPIO Inès Varhol
2024-02-07 13:23 ` [PATCH v4 1/3] hw/gpio: Implement " Inès Varhol
2024-02-23 12:17 ` Philippe Mathieu-Daudé
2024-02-07 13:23 ` [PATCH v4 2/3] hw/arm: Connect STM32L4x5 GPIO to STM32L4x5 SoC Inès Varhol
2024-02-23 12:25 ` Philippe Mathieu-Daudé
2024-02-07 13:23 ` [PATCH v4 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase Inès Varhol
2024-02-23 12:26 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a71aa6a-0fe0-4407-a2f3-3fb9bacaed8c@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=arnaud.minier@telecom-paris.fr \
--cc=ines.varhol@telecom-paris.fr \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.tardieu@telecom-paris.fr \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).