[Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections

[Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections

[Thomas Huth]

There is currently a "e500" machine section and a "ppce500" device
section in the maintainers file - with some oddities: The wildcard
in the device section also covers the files from the machine section.
And hw/pci-host/ppce500.c is in the device section, while its header
is in the machine section.
This is really quite confusing, and I don't see a reason why we really
need two sections here, so let's simply merge them.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index eac36b6..30dbe37 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -957,9 +957,10 @@ e500
 M: David Gibson <david@gibson.dropbear.id.au>
 L: qemu-ppc@nongnu.org
 S: Odd Fixes
-F: hw/ppc/e500.[hc]
-F: hw/ppc/e500plat.c
+F: hw/ppc/e500*
 F: hw/gpio/mpc8xxx.c
+F: hw/net/fsl_etsec/
+F: hw/pci-host/ppce500.c
 F: include/hw/ppc/ppc_e500.h
 F: include/hw/pci-host/ppce500.h
 F: pc-bios/u-boot.e500
@@ -1316,14 +1317,6 @@ F: hw/i2c/ppc4xx_i2c.c
 F: include/hw/ppc/ppc4xx.h
 F: include/hw/i2c/ppc4xx_i2c.h
 
-ppce500
-M: David Gibson <david@gibson.dropbear.id.au>
-L: qemu-ppc@nongnu.org
-S: Odd Fixes
-F: hw/ppc/e500*
-F: hw/pci-host/ppce500.c
-F: hw/net/fsl_etsec/
-
 Character devices
 M: Marc-André Lureau <marcandre.lureau@redhat.com>
 R: Paolo Bonzini <pbonzini@redhat.com>
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections

[Philippe Mathieu-Daudé]

On 1/30/19 5:22 PM, Thomas Huth wrote:
> There is currently a "e500" machine section and a "ppce500" device
> section in the maintainers file - with some oddities: The wildcard
> in the device section also covers the files from the machine section.
> And hw/pci-host/ppce500.c is in the device section, while its header
> is in the machine section.
> This is really quite confusing, and I don't see a reason why we really
> need two sections here, so let's simply merge them.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  MAINTAINERS | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index eac36b6..30dbe37 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -957,9 +957,10 @@ e500
>  M: David Gibson <david@gibson.dropbear.id.au>
>  L: qemu-ppc@nongnu.org
>  S: Odd Fixes
> -F: hw/ppc/e500.[hc]
> -F: hw/ppc/e500plat.c
> +F: hw/ppc/e500*
>  F: hw/gpio/mpc8xxx.c
> +F: hw/net/fsl_etsec/
> +F: hw/pci-host/ppce500.c
>  F: include/hw/ppc/ppc_e500.h
>  F: include/hw/pci-host/ppce500.h
>  F: pc-bios/u-boot.e500
> @@ -1316,14 +1317,6 @@ F: hw/i2c/ppc4xx_i2c.c
>  F: include/hw/ppc/ppc4xx.h
>  F: include/hw/i2c/ppc4xx_i2c.h
>  
> -ppce500
> -M: David Gibson <david@gibson.dropbear.id.au>
> -L: qemu-ppc@nongnu.org
> -S: Odd Fixes
> -F: hw/ppc/e500*
> -F: hw/pci-host/ppce500.c
> -F: hw/net/fsl_etsec/
> -
>  Character devices
>  M: Marc-André Lureau <marcandre.lureau@redhat.com>
>  R: Paolo Bonzini <pbonzini@redhat.com>
> 

Re: [Qemu-devel] [PATCH] MAINTAINERS: Merge the two e500 sections

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

On Wed, Jan 30, 2019 at 05:22:25PM +0100, Thomas Huth wrote:
> There is currently a "e500" machine section and a "ppce500" device
> section in the maintainers file - with some oddities: The wildcard
> in the device section also covers the files from the machine section.
> And hw/pci-host/ppce500.c is in the device section, while its header
> is in the machine section.
> This is really quite confusing, and I don't see a reason why we really
> need two sections here, so let's simply merge them.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Applied to ppc-for-4.0, thanks.

> ---
>  MAINTAINERS | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index eac36b6..30dbe37 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -957,9 +957,10 @@ e500
>  M: David Gibson <david@gibson.dropbear.id.au>
>  L: qemu-ppc@nongnu.org
>  S: Odd Fixes
> -F: hw/ppc/e500.[hc]
> -F: hw/ppc/e500plat.c
> +F: hw/ppc/e500*
>  F: hw/gpio/mpc8xxx.c
> +F: hw/net/fsl_etsec/
> +F: hw/pci-host/ppce500.c
>  F: include/hw/ppc/ppc_e500.h
>  F: include/hw/pci-host/ppce500.h
>  F: pc-bios/u-boot.e500
> @@ -1316,14 +1317,6 @@ F: hw/i2c/ppc4xx_i2c.c
>  F: include/hw/ppc/ppc4xx.h
>  F: include/hw/i2c/ppc4xx_i2c.h
>  
> -ppce500
> -M: David Gibson <david@gibson.dropbear.id.au>
> -L: qemu-ppc@nongnu.org
> -S: Odd Fixes
> -F: hw/ppc/e500*
> -F: hw/pci-host/ppce500.c
> -F: hw/net/fsl_etsec/
> -
>  Character devices
>  M: Marc-André Lureau <marcandre.lureau@redhat.com>
>  R: Paolo Bonzini <pbonzini@redhat.com>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]